Refactor EML Taxa Logic into it's own view

[robyngit]

• Fixes some linting errors
• Adds a few taxa related methods to EML model (including unit tests)

Fixes issue #25 (the oldest issue in MetacatUI currently :) )

[github-actions]

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

---

🚫 [eslint] <no-unused-vars> _{reported by reviewdog 🐶}
'nodeNameMap' is assigned a value but never used. Allowed unused vars must match /^_/u.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 811 in a3782ea

const nodeNameMap = this.nodeNameMap();

---

⚠️ [eslint] <func-names> _{reported by reviewdog 🐶}
Unexpected unnamed function.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 817 in a3782ea

function (fieldName) {

---

⚠️ [eslint] <func-names> _{reported by reviewdog 🐶}
Unexpected unnamed function.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 871 in a3782ea

function (field) {

---

⚠️ [eslint] <func-names> _{reported by reviewdog 🐶}
Unexpected unnamed function.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 886 in a3782ea

function (thisTextModel, i) {

---

🚫 [eslint] <vars-on-top> _{reported by reviewdog 🐶}
All 'var' declarations must be at the top of the function scope.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 913 in a3782ea

var coverageNode = $(document.createElement("coverage"));

---

🚫 [eslint] <no-var> _{reported by reviewdog 🐶}
Unexpected var, use let or const instead.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 913 in a3782ea

var coverageNode = $(document.createElement("coverage"));

---

🚫 [eslint] <block-scoped-var> _{reported by reviewdog 🐶}
'coverageNode' declared on line 919 column 15 is used outside of binding context.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 913 in a3782ea

var coverageNode = $(document.createElement("coverage"));

---

🚫 [eslint] <block-scoped-var> _{reported by reviewdog 🐶}
'coverageNode' declared on line 919 column 15 is used outside of binding context.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 916 in a3782ea

if (coveragePosition) coveragePosition.after(coverageNode);

---

🚫 [eslint] <block-scoped-var> _{reported by reviewdog 🐶}
'coverageNode' declared on line 919 column 15 is used outside of binding context.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 917 in a3782ea

else datasetNode.append(coverageNode);

---

🚫 [eslint] <vars-on-top> _{reported by reviewdog 🐶}
All 'var' declarations must be at the top of the function scope.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 919 in a3782ea

var coverageNode = datasetNode.children("coverage").first();

---

🚫 [eslint] <no-var> _{reported by reviewdog 🐶}
Unexpected var, use let or const instead.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 919 in a3782ea

var coverageNode = datasetNode.children("coverage").first();

---

🚫 [eslint] <no-redeclare> _{reported by reviewdog 🐶}
'coverageNode' is already defined.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 919 in a3782ea

var coverageNode = datasetNode.children("coverage").first();

---

🚫 [eslint] <block-scoped-var> _{reported by reviewdog 🐶}
'coverageNode' declared on line 913 column 15 is used outside of binding context.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 919 in a3782ea

var coverageNode = datasetNode.children("coverage").first();

---

🚫 [eslint] <block-scoped-var> _{reported by reviewdog 🐶}
'coverageNode' declared on line 913 column 15 is used outside of binding context.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 963 in a3782ea

coverageNode.children("geographiccoverage").remove();

---

🚫 [eslint] <block-scoped-var> _{reported by reviewdog 🐶}
'coverageNode' declared on line 919 column 15 is used outside of binding context.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 963 in a3782ea

coverageNode.children("geographiccoverage").remove();

---

🚫 [eslint] <block-scoped-var> _{reported by reviewdog 🐶}
'coverageNode' declared on line 913 column 15 is used outside of binding context.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 983 in a3782ea

const existingTaxonCov = coverageNode.children("taxonomiccoverage");

---

🚫 [eslint] <block-scoped-var> _{reported by reviewdog 🐶}
'coverageNode' declared on line 919 column 15 is used outside of binding context.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 983 in a3782ea

const existingTaxonCov = coverageNode.children("taxonomiccoverage");

---

🚫 [eslint] <block-scoped-var> _{reported by reviewdog 🐶}
'coverageNode' declared on line 913 column 15 is used outside of binding context.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1000 in a3782ea

coverageNode.append(taxonCoverage.updateDOM());

---

🚫 [eslint] <block-scoped-var> _{reported by reviewdog 🐶}
'coverageNode' declared on line 919 column 15 is used outside of binding context.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1000 in a3782ea

coverageNode.append(taxonCoverage.updateDOM());

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1010 in a3782ea

sortedTaxonModels.notEmpty.length == 0

---

🚫 [eslint] <block-scoped-var> _{reported by reviewdog 🐶}
'coverageNode' declared on line 913 column 15 is used outside of binding context.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1029 in a3782ea

coverageNode.append(temporalCoverage.updateDOM());

---

🚫 [eslint] <block-scoped-var> _{reported by reviewdog 🐶}
'coverageNode' declared on line 919 column 15 is used outside of binding context.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1029 in a3782ea

coverageNode.append(temporalCoverage.updateDOM());

---

🚫 [eslint] <block-scoped-var> _{reported by reviewdog 🐶}
'coverageNode' declared on line 913 column 15 is used outside of binding context.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1040 in a3782ea

if (!coverageNode.children("temporalcoverage").children().length) {

---

🚫 [eslint] <block-scoped-var> _{reported by reviewdog 🐶}
'coverageNode' declared on line 919 column 15 is used outside of binding context.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1040 in a3782ea

if (!coverageNode.children("temporalcoverage").children().length) {

---

🚫 [eslint] <block-scoped-var> _{reported by reviewdog 🐶}
'coverageNode' declared on line 913 column 15 is used outside of binding context.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1041 in a3782ea

coverageNode.children("temporalcoverage").remove();

---

🚫 [eslint] <block-scoped-var> _{reported by reviewdog 🐶}
'coverageNode' declared on line 919 column 15 is used outside of binding context.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1041 in a3782ea

coverageNode.children("temporalcoverage").remove();

---

🚫 [eslint] <block-scoped-var> _{reported by reviewdog 🐶}
'coverageNode' declared on line 913 column 15 is used outside of binding context.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1045 in a3782ea

if (coverageNode.children().length == 0) {

---

🚫 [eslint] <block-scoped-var> _{reported by reviewdog 🐶}
'coverageNode' declared on line 919 column 15 is used outside of binding context.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1045 in a3782ea

if (coverageNode.children().length == 0) {

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1045 in a3782ea

if (coverageNode.children().length == 0) {

---

🚫 [eslint] <block-scoped-var> _{reported by reviewdog 🐶}
'coverageNode' declared on line 913 column 15 is used outside of binding context.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1046 in a3782ea

coverageNode.remove();

---

🚫 [eslint] <block-scoped-var> _{reported by reviewdog 🐶}
'coverageNode' declared on line 919 column 15 is used outside of binding context.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1046 in a3782ea

coverageNode.remove();

---

⚠️ [eslint] <func-names> _{reported by reviewdog 🐶}
Unexpected unnamed function.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1175 in a3782ea

function (entity, position) {

---

🚫 [eslint] <no-plusplus> _{reported by reviewdog 🐶}
Unary operator '++' used.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1202 in a3782ea

i++

---

⚠️ [eslint] <func-names> _{reported by reviewdog 🐶}
Unexpected unnamed function.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1240 in a3782ea

function (rootEMLNode) {

---

⚠️ [eslint] <func-names> _{reported by reviewdog 🐶}
Unexpected unnamed function.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1259 in a3782ea

function (party, i) {

---

🚫 [eslint] <no-unused-vars> _{reported by reviewdog 🐶}
'i' is defined but never used. Allowed unused args must match /^_/u.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1259 in a3782ea

function (party, i) {

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1287 in a3782ea

if (type == "contact" && !this.get("contact").length) {

---

⚠️ [eslint] <func-names> _{reported by reviewdog 🐶}
Unexpected unnamed function.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1294 in a3782ea

function (creator) {

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1316 in a3782ea

if (this.get("keywordSets").length == 0) return;

---

🚫 [eslint] <no-plusplus> _{reported by reviewdog 🐶}
Unary operator '++' used.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1332 in a3782ea

for (let i = models.length; i < nodes.length; i++) {

---

🚫 [eslint] <vars-on-top> _{reported by reviewdog 🐶}
All 'var' declarations must be at the top of the function scope.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1360 in a3782ea

var party = new EMLParty({ parentModel: this, type: "creator" });

---

🚫 [eslint] <no-var> _{reported by reviewdog 🐶}
Unexpected var, use let or const instead.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1360 in a3782ea

var party = new EMLParty({ parentModel: this, type: "creator" });

---

🚫 [eslint] <block-scoped-var> _{reported by reviewdog 🐶}
'party' declared on line 1369 column 15 is used outside of binding context.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1360 in a3782ea

var party = new EMLParty({ parentModel: this, type: "creator" });

---

🚫 [eslint] <block-scoped-var> _{reported by reviewdog 🐶}
'party' declared on line 1369 column 15 is used outside of binding context.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1364 in a3782ea

this.set("creator", [party]);

---

🚫 [eslint] <vars-on-top> _{reported by reviewdog 🐶}
All 'var' declarations must be at the top of the function scope.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1369 in a3782ea

var party = new EMLParty({ parentModel: this, type: "contact" });

---

🚫 [eslint] <no-var> _{reported by reviewdog 🐶}
Unexpected var, use let or const instead.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1369 in a3782ea

var party = new EMLParty({ parentModel: this, type: "contact" });

---

🚫 [eslint] <no-redeclare> _{reported by reviewdog 🐶}
'party' is already defined.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1369 in a3782ea

var party = new EMLParty({ parentModel: this, type: "contact" });

---

🚫 [eslint] <block-scoped-var> _{reported by reviewdog 🐶}
'party' declared on line 1360 column 15 is used outside of binding context.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1369 in a3782ea

var party = new EMLParty({ parentModel: this, type: "contact" });

---

🚫 [eslint] <block-scoped-var> _{reported by reviewdog 🐶}
'party' declared on line 1360 column 15 is used outside of binding context.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1373 in a3782ea

this.set("contact", [party]);

---

🚫 [eslint] <vars-on-top> _{reported by reviewdog 🐶}
All 'var' declarations must be at the top of the function scope.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1378 in a3782ea

var model = this;

---

🚫 [eslint] <no-var> _{reported by reviewdog 🐶}
Unexpected var, use let or const instead.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1378 in a3782ea

var model = this;

---

🚫 [eslint] <consistent-return> _{reported by reviewdog 🐶}
Method 'save' expected a return value.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1391 in a3782ea

return;

---

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'md5' is not defined.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1418 in a3782ea

const checksum = md5(xml);

---

🚫 [eslint] <vars-on-top> _{reported by reviewdog 🐶}
All 'var' declarations must be at the top of the function scope.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1444 in a3782ea

var model = this;

---

🚫 [eslint] <no-var> _{reported by reviewdog 🐶}
Unexpected var, use let or const instead.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1444 in a3782ea

var model = this;

---

🚫 [eslint] <no-redeclare> _{reported by reviewdog 🐶}
'model' is already defined.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1444 in a3782ea

var model = this;

---

🚫 [eslint] <block-scoped-var> _{reported by reviewdog 🐶}
'model' declared on line 1378 column 15 is used outside of binding context.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1444 in a3782ea

var model = this;

---

🚫 [eslint] <block-scoped-var> _{reported by reviewdog 🐶}
'model' declared on line 1378 column 15 is used outside of binding context.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1467 in a3782ea

model.set("uploadProgress", percentComplete);

---

🚫 [eslint] <no-shadow> _{reported by reviewdog 🐶}
'model' is already declared in the upper scope on line 1378 column 15.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1475 in a3782ea

success(model, response, xhr) {

---

🚫 [eslint] <no-unused-vars> _{reported by reviewdog 🐶}
'response' is defined but never used. Allowed unused args must match /^_/u.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1475 in a3782ea

success(model, response, xhr) {

---

🚫 [eslint] <no-unused-vars> _{reported by reviewdog 🐶}
'xhr' is defined but never used. Allowed unused args must match /^_/u.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1475 in a3782ea

success(model, response, xhr) {

---

🚫 [eslint] <no-shadow> _{reported by reviewdog 🐶}
'model' is already declared in the upper scope on line 1378 column 15.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1483 in a3782ea

error(model, response, xhr) {

---

🚫 [eslint] <no-unused-vars> _{reported by reviewdog 🐶}
'xhr' is defined but never used. Allowed unused args must match /^_/u.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1483 in a3782ea

error(model, response, xhr) {

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1492 in a3782ea

(response.status == 408 || response.status == 0)

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1492 in a3782ea

(response.status == 408 || response.status == 0)

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1515 in a3782ea

if (!errorMsg || response.status == 408 || response.status == 0)

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1515 in a3782ea

if (!errorMsg || response.status == 408 || response.status == 0)

---

🚫 [eslint] <consistent-return> _{reported by reviewdog 🐶}
Expected to return a value at the end of method 'validate'.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1570 in a3782ea

validate() {

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1621 in a3782ea

if (errors.temporalCoverage.length == 0) {

---

⚠️ [eslint] <func-names> _{reported by reviewdog 🐶}
Unexpected unnamed function.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1635 in a3782ea

function (type) {

---

🚫 [eslint] <no-unused-vars> _{reported by reviewdog 🐶}
'i' is defined but never used. Allowed unused args must match /^_/u.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1639 in a3782ea

(person, i) => {

---

🚫 [eslint] <no-unused-vars> _{reported by reviewdog 🐶}
'i' is defined but never used. Allowed unused args must match /^_/u.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1654 in a3782ea

(geoCoverageModel, i) => {

---

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'field' is not defined.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1712 in a3782ea

for ([field, isRequired] of Object.entries(

---

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'isRequired' is not defined.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1712 in a3782ea

for ([field, isRequired] of Object.entries(

---

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'isRequired' is not defined.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1716 in a3782ea

if (!isRequired) continue;

---

🚫 [eslint] <no-continue> _{reported by reviewdog 🐶}
Unexpected use of continue statement.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1716 in a3782ea

if (!isRequired) continue;

---

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'field' is not defined.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1718 in a3782ea

if (field == "alternateIdentifier") {

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1718 in a3782ea

if (field == "alternateIdentifier") {

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1723 in a3782ea

(altId) => altId.trim() == "",

---

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'field' is not defined.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1770 in a3782ea

else if (field == "methods") {

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1770 in a3782ea

else if (field == "methods") {

---

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'field' is not defined.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1789 in a3782ea

} else if (field == "abstract") {

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1789 in a3782ea

} else if (field == "abstract") {

---

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'field' is not defined.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1792 in a3782ea

} else if (field == "dataSensitivity") {

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1792 in a3782ea

} else if (field == "dataSensitivity") {

---

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'field' is not defined.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1802 in a3782ea

.includes(field)

---

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'field' is not defined.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1805 in a3782ea

if (EMLParty.prototype.defaults().roleOptions?.includes(field)) {

---

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'field' is not defined.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1810 in a3782ea

.includes(field)

---

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'field' is not defined.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1812 in a3782ea

errors[field] =

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1815 in a3782ea

(t) => t.dataCategory == field,

---

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'field' is not defined.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1815 in a3782ea

(t) => t.dataCategory == field,

---

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'field' is not defined.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1819 in a3782ea

} else if (!this.get(field)?.length) {

---

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'field' is not defined.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1820 in a3782ea

errors[field] =

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1823 in a3782ea

(t) => t.dataCategory == field,

---

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'field' is not defined.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1823 in a3782ea

(t) => t.dataCategory == field,

---

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'field' is not defined.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1827 in a3782ea

} else if (!this.get(field) || !this.get(field)?.length) {

---

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'field' is not defined.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1827 in a3782ea

} else if (!this.get(field) || !this.get(field)?.length) {

---

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'field' is not defined.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1828 in a3782ea

errors[field] = `Provide a ${field}.`;

---

🚫 [eslint] <no-undef> _{reported by reviewdog 🐶}
'field' is not defined.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1828 in a3782ea

errors[field] = `Provide a ${field}.`;

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1900 in a3782ea

if (position == -1) {

---

🚫 [eslint] <no-plusplus> _{reported by reviewdog 🐶}
Unary operator '--' used.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1906 in a3782ea

for (let i = position - 1; i >= 0; i--) {

---

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in 'super'.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1919 in a3782ea

if (this.constructor.__super__.hasUpdates.call(this)) return true;

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1932 in a3782ea

if (typeof position === "undefined" || position == -1)

---

🚫 [eslint] <consistent-return> _{reported by reviewdog 🐶}
Expected to return a value at the end of function.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1970 in a3782ea

function (e) {

---

⚠️ [eslint] <func-names> _{reported by reviewdog 🐶}
Unexpected unnamed function.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1970 in a3782ea

function (e) {

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1972 in a3782ea

if (e.get("xmlID") == dataONEObj.getXMLSafeID()) return true;

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1975 in a3782ea

e.get("physicalMD5Checksum") == dataONEObj.get("checksum") &&

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1976 in a3782ea

dataONEObj.get("checksumAlgorithm").toUpperCase() == "MD5"

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1981 in a3782ea

e.get("downloadID") == dataONEObj.get("id")

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 1995 in a3782ea

fileNameFromEML.replace(/ /g, "_").toLowerCase() ==

---

🚫 [eslint] <consistent-return> _{reported by reviewdog 🐶}
Expected to return a value at the end of arrow function.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2003 in a3782ea

const otherMatchingEntity = _.find(otherEntities, (otherE) => {

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2010 in a3782ea

otherFileNameFromEML == dataONEObj.get("fileName") ||

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2011 in a3782ea

otherFileNameFromEML.replace(/ /g, "_") ==

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2028 in a3782ea

if (entity.get("dataONEObject") == dataONEObj) {

---

🚫 [eslint] <consistent-return> _{reported by reviewdog 🐶}
Method 'getEntity' expected a return value.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2034 in a3782ea

return;

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2052 in a3782ea

e.get("formatName") ==

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2056 in a3782ea

if (matchingTypes.length == 1) {

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2065 in a3782ea

if (this.get("entities").length == 1) {

---

⚠️ [eslint] <func-names> _{reported by reviewdog 🐶}
Unexpected unnamed function.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2095 in a3782ea

this.listenTo(dataONEObject, "errorSaving", function () {

---

⚠️ [eslint] <func-names> _{reported by reviewdog 🐶}
Unexpected unnamed function.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2099 in a3782ea

this.listenToOnce(dataONEObject, "successSaving", function () {

---

⚠️ [eslint] <jsdoc/valid-types> _{reported by reviewdog 🐶}
Syntax error in namepath: partyModel:

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2156 in a3782ea

* @param {EMLParty} partyModel: The EMLParty model we're moving

---

⚠️ [eslint] <jsdoc/check-param-names> _{reported by reviewdog 🐶}
Expected @param names to be "partyModel". Got "partyModel:, partyModel".

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2156 in a3782ea

* @param {EMLParty} partyModel: The EMLParty model we're moving

---

⚠️ [eslint] <jsdoc/require-param-description> _{reported by reviewdog 🐶}
Missing JSDoc @param "partyModel" description.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2157 in a3782ea

* @param partyModel

---

⚠️ [eslint] <jsdoc/require-param-type> _{reported by reviewdog 🐶}
Missing JSDoc @param "partyModel" type.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2157 in a3782ea

* @param partyModel

---

⚠️ [eslint] <jsdoc/valid-types> _{reported by reviewdog 🐶}
Syntax error in namepath: partyModel:

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2202 in a3782ea

* @param {EMLParty} partyModel: The EMLParty model we're moving

---

⚠️ [eslint] <jsdoc/check-param-names> _{reported by reviewdog 🐶}
Expected @param names to be "partyModel". Got "partyModel:, partyModel".

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2202 in a3782ea

* @param {EMLParty} partyModel: The EMLParty model we're moving

---

⚠️ [eslint] <jsdoc/require-param-description> _{reported by reviewdog 🐶}
Missing JSDoc @param "partyModel" description.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2203 in a3782ea

* @param partyModel

---

⚠️ [eslint] <jsdoc/require-param-type> _{reported by reviewdog 🐶}
Missing JSDoc @param "partyModel" type.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2203 in a3782ea

* @param partyModel

---

🚫 [eslint] <consistent-return> _{reported by reviewdog 🐶}
Expected to return a value at the end of method 'getPartiesByType'.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2280 in a3782ea

getPartiesByType(partyType) {

---

⚠️ [eslint] <no-console> _{reported by reviewdog 🐶}
Unexpected console statement.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2303 in a3782ea

console.log(

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2364 in a3782ea

if (this.get("uploadStatus") == "e" && this.get("errorMessage")) {

---

🚫 [eslint] <no-param-reassign> _{reported by reviewdog 🐶}
Assignment to function parameter 'textString'.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2395 in a3782ea

textString = textString.trim();

---

🚫 [eslint] <no-param-reassign> _{reported by reviewdog 🐶}
Assignment to function parameter 'textString'.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2404 in a3782ea

textString = textString.replace(xmlNode, tagName);

---

🚫 [eslint] <no-control-regex> _{reported by reviewdog 🐶}
Unexpected control character(s) in regular expression: \x09, \x0a, \x0d.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2411 in a3782ea

/[^\u0009\u000a\u000d\u0020-\uD7FF\uE000-\uFFFD]/g;

---

🚫 [eslint] <no-param-reassign> _{reported by reviewdog 🐶}
Assignment to function parameter 'textString'.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2412 in a3782ea

textString = textString.replace(invalidCharsRegEx, "");

---

🚫 [eslint] <prefer-const> _{reported by reviewdog 🐶}
'referencesList' is never reassigned. Use 'const' instead.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2430 in a3782ea

referencesList = xmlDOM.getElementsByTagName("references");

---

🚫 [eslint] <no-shadow> _{reported by reviewdog 🐶}
'referencesList' is already declared in the upper scope on line 2424 column 13.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2436 in a3782ea

(referencesEl, index, referencesList) => {

---

🚫 [eslint] <prefer-destructuring> _{reported by reviewdog 🐶}
Use array destructuring.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2442 in a3782ea

referencesParentEl = $(referencesEl).parent()[0];

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '!==' and instead saw '!='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2443 in a3782ea

if (typeof referencedID !== "undefined" && referencedID != "") {

---

🚫 [eslint] <prefer-destructuring> _{reported by reviewdog 🐶}
Use array destructuring.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2470 in a3782ea

title = this.get("title")[0];

---

⚠️ [eslint] <jsdoc/valid-types> _{reported by reviewdog 🐶}
Syntax error in namepath: eml:

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2513 in a3782ea

* @param {Element} eml: The root eml:eml element to modify

---

⚠️ [eslint] <jsdoc/check-param-names> _{reported by reviewdog 🐶}
Expected @param names to be "eml". Got "eml:, eml".

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2513 in a3782ea

* @param {Element} eml: The root eml:eml element to modify

---

⚠️ [eslint] <jsdoc/require-param-description> _{reported by reviewdog 🐶}
Missing JSDoc @param "eml" description.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2514 in a3782ea

* @param eml

---

⚠️ [eslint] <jsdoc/require-param-type> _{reported by reviewdog 🐶}
Missing JSDoc @param "eml" type.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2514 in a3782ea

* @param eml

---

⚠️ [eslint] <jsdoc/check-property-names> _{reported by reviewdog 🐶}
@Property path declaration ("annotationData.elementName") appears before any real property.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2556 in a3782ea

* @property {string} [annotationData.elementName] The name of the EML Element that this

---

🚫 [eslint] <no-param-reassign> _{reported by reviewdog 🐶}
Assignment to property of function parameter 'annotationData'.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2576 in a3782ea

delete annotationData.elementName;

---

🚫 [eslint] <no-param-reassign> _{reported by reviewdog 🐶}
Assignment to property of function parameter 'annotationData'.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2580 in a3782ea

delete annotationData.allowDuplicates;

---

🚫 [eslint] <eqeqeq> _{reported by reviewdog 🐶}
Expected '===' and instead saw '=='.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2586 in a3782ea

if (elementName == "dataset") {

---

⚠️ [eslint] <jsdoc/require-returns-description> _{reported by reviewdog 🐶}
Missing JSDoc @returns description.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2616 in a3782ea

* @returns {EMLAnnotation[]|undefined}

---

⚠️ [eslint] <no-console> _{reported by reviewdog 🐶}
Unexpected console statement.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2631 in a3782ea

console.error("Failed to get Data Sensitivity from EML model: ", e);

---

⚠️ [eslint] <jsdoc/check-types> _{reported by reviewdog 🐶}
Invalid JSDoc @typedef "TaxonomicClassification" type "Object"; prefer: "object".

metacatui/src/js/models/metadata/eml211/EMLTaxonCoverage.js

Line 8 in a3782ea

* @typedef {Object} TaxonomicClassification

---

⚠️ [eslint] <func-names> _{reported by reviewdog 🐶}
Unexpected unnamed method 'renderTaxa'.

metacatui/src/js/views/metadata/EML211View.js

Line 1182 in a3782ea

renderTaxa: function () {

---

🚫 [eslint] <object-shorthand> _{reported by reviewdog 🐶}
Expected method shorthand.

metacatui/src/js/views/metadata/EML211View.js

Lines 1182 to 1196 in a3782ea

	renderTaxa: function () {
	// const taxaSectionEl = this.$(".section.taxa");
	const taxaSectionEl = document.querySelector(".section.taxa");
	if (!taxaSectionEl) return;
	// TODO
	this.taxaView = new EMLTaxonView({
	el: taxaSectionEl,
	parentModel: this.model,
	taxonArray: this.model.get("taxonCoverage"),
	edit: this.edit,
	// isNew: false, // needed?
	// parentView: this, // needed?
	}).render();
	},

---

⚠️ [eslint] <func-names> _{reported by reviewdog 🐶}
Unexpected unnamed method 'updateRadioButtons'.

metacatui/src/js/views/metadata/EML211View.js

Line 2138 in a3782ea

updateRadioButtons: function (e) {

---

🚫 [eslint] <spaced-comment> _{reported by reviewdog 🐶}
Expected exception block, space or tab after '//' in comment.

metacatui/src/js/views/metadata/EML211View.js

Line 2139 in a3782ea

//Get the element of this radio button set that is checked

[github-actions]

🚫 [eslint] <prefer-arrow-callback> _{reported by reviewdog 🐶}
Unexpected function expression.

metacatui/src/js/models/metadata/eml211/EMLTaxonCoverage.js

Lines 1 to 465 in a3782ea

	define(["jquery", "underscore", "backbone", "models/DataONEObject"], function (
	$,
	_,
	Backbone,
	DataONEObject,
	) {
	/**
	* @typedef {Object} TaxonomicClassification
	* @property {string} taxonRankName - The name of the taxonomic rank, for
	* example, Domain, Kingdom, etc.
	* @property {string} taxonRankValue - The value for the given taxonomic rank,
	* for example, Animalia, Chordata, etc.
	* @property {string[]} commonName - Common name(s) for the taxon, for example
	* ["Animal"]
	* @property {Object[]} taxonId - A taxon identifier from a controlled
	* vocabulary, for example, ITIS, NCBI, etc.
	* @property {string} taxonId.provider - The provider of the taxon identifier,
	* given as a URI, for example http://www.itis.gov
	* @property {string} taxonId.value - The identifier from the provider, for
	* example, 180092
	* @property {Object[]} taxonomicClassification - A nested taxonomic
	* classification, since taxonomy is represented as a hierarchy in EML.
	*/
	/**
	* @class EMLTaxonCoverage
	* @classdesc The EMLTaxonCoverage model represents the taxonomic coverage of
	* a dataset. It includes a general description of the taxonomic coverage, as
	* well as a list of taxonomic classifications.
	* @classcategory Models/Metadata/EML
	* @extends Backbone.Model
	* @constructor
	*/
	var EMLTaxonCoverage = Backbone.Model.extend(
	/** @lends EMLTaxonCoverage.prototype */ {
	/**
	* Returns the default properties for this model. Defined here.
	* @type {Object}
	* @property {string} objectXML - The XML string for this model
	* @property {Element} objectDOM - The XML DOM for this model
	* @property {EML211} parentModel - The parent EML211 model
	* @property {taxonomicClassification[]} taxonomicClassification - An array
	* of taxonomic classifications, defining the taxonomic coverage of the
	* dataset
	* @property {string} generalTaxonomicCoverage - A general description of the
	* taxonomic coverage of the dataset
	*/
	defaults: {
	objectXML: null,
	objectDOM: null,
	parentModel: null,
	taxonomicClassification: [],
	generalTaxonomicCoverage: null,
	},
	initialize: function (attributes) {
	if (attributes.objectDOM) this.set(this.parse(attributes.objectDOM));
	this.on("change:taxonomicClassification", this.trickleUpChange);
	this.on("change:taxonomicClassification", this.updateDOM);
	},
	/*
	* Maps the lower-case EML node names (valid in HTML DOM) to the camel-cased
	* EML node names (valid in EML). Used during parse() and serialize()
	*/
	nodeNameMap: function () {
	return {
	generaltaxonomiccoverage: "generalTaxonomicCoverage",
	taxonomicclassification: "taxonomicClassification",
	taxonrankname: "taxonRankName",
	taxonrankvalue: "taxonRankValue",
	taxonomiccoverage: "taxonomicCoverage",
	taxonomicsystem: "taxonomicSystem",
	classificationsystem: "classificationSystem",
	classificationsystemcitation: "classificationSystemCitation",
	classificationsystemmodifications:
	"classificationSystemModifications",
	identificationreference: "identificationReference",
	identifiername: "identifierName",
	taxonomicprocedures: "taxonomicProcedures",
	taxonomiccompleteness: "taxonomicCompleteness",
	taxonid: "taxonId",
	commonname: "commonName",
	};
	},
	parse: function (objectDOM) {
	if (!objectDOM) var xml = this.get("objectDOM");
	var model = this,
	taxonomicClassifications = $(objectDOM).children(
	"taxonomicclassification",
	),
	modelJSON = {
	taxonomicClassification: _.map(
	taxonomicClassifications,
	function (tc) {
	return model.parseTaxonomicClassification(tc);
	},
	),
	generalTaxonomicCoverage: $(objectDOM)
	.children("generaltaxonomiccoverage")
	.first()
	.text(),
	};
	return modelJSON;
	},
	parseTaxonomicClassification: function (classification) {
	var id = $(classification).attr("id");
	var rankName = $(classification).children("taxonrankname");
	var rankValue = $(classification).children("taxonrankvalue");
	var commonName = $(classification).children("commonname");
	var taxonId = $(classification).children("taxonId");
	var taxonomicClassification = $(classification).children(
	"taxonomicclassification",
	);
	var model = this,
	modelJSON = {
	id: id,
	taxonRankName: $(rankName).text().trim(),
	taxonRankValue: $(rankValue).text().trim(),
	commonName: _.map(commonName, function (cn) {
	return $(cn).text().trim();
	}),
	taxonId: _.map(taxonId, function (tid) {
	return {
	provider: $(tid).attr("provider").trim(),
	value: $(tid).text().trim(),
	};
	}),
	taxonomicClassification: _.map(
	taxonomicClassification,
	function (tc) {
	return model.parseTaxonomicClassification(tc);
	},
	),
	};
	if (
	Array.isArray(modelJSON.taxonomicClassification) &&
	!modelJSON.taxonomicClassification.length
	)
	modelJSON.taxonomicClassification = {};
	return modelJSON;
	},
	serialize: function () {
	var objectDOM = this.updateDOM(),
	xmlString = objectDOM.outerHTML;
	//Camel-case the XML
	xmlString = this.formatXML(xmlString);
	return xmlString;
	},
	/*
	* Makes a copy of the original XML DOM and updates it with the new values
	* from the model.
	*/
	updateDOM: function () {
	var objectDOM = this.get("objectDOM")
	? this.get("objectDOM").cloneNode(true)
	: document.createElement("taxonomiccoverage");
	$(objectDOM).empty();
	// generalTaxonomicCoverage
	var generalCoverage = this.get("generalTaxonomicCoverage");
	if (_.isString(generalCoverage) && generalCoverage.length > 0) {
	$(objectDOM).append(
	$(document.createElement("generaltaxonomiccoverage")).text(
	this.get("generalTaxonomicCoverage"),
	),
	);
	}
	// taxonomicClassification(s)
	var classifications = this.get("taxonomicClassification");
	if (
	typeof classifications === "undefined" ||
	classifications.length === 0
	) {
	return objectDOM;
	}
	for (var i = 0; i < classifications.length; i++) {
	$(objectDOM).append(
	this.createTaxonomicClassificationDOM(classifications[i]),
	);
	}
	// Remove empty (zero-length or whitespace-only) nodes
	$(objectDOM)
	.find("*")
	.filter(function () {
	return $.trim(this.innerHTML) === "";
	})
	.remove();
	return objectDOM;
	},
	/*
	* Create the DOM for a single EML taxonomicClassification.
	* This function is currently recursive!
	*/
	createTaxonomicClassificationDOM: function (classification) {
	var id = classification.id,
	taxonRankName = classification.taxonRankName || "",
	taxonRankValue = classification.taxonRankValue || "",
	commonName = classification.commonName || "",
	taxonId = classification.taxonId,
	finishedEl;
	if (!taxonRankName || !taxonRankValue) return "";
	finishedEl = $(document.createElement("taxonomicclassification"));
	if (typeof id === "string" && id.length > 0) {
	$(finishedEl).attr("id", id);
	}
	if (taxonRankName && taxonRankName.length > 0) {
	$(finishedEl).append(
	$(document.createElement("taxonrankname")).text(taxonRankName),
	);
	}
	if (taxonRankValue && taxonRankValue.length > 0) {
	$(finishedEl).append(
	$(document.createElement("taxonrankvalue")).text(taxonRankValue),
	);
	}
	if (commonName && commonName.length > 0) {
	$(finishedEl).append(
	$(document.createElement("commonname")).text(commonName),
	);
	}
	if (taxonId) {
	if (!Array.isArray(taxonId)) taxonId = [taxonId];
	_.each(taxonId, function (el) {
	var taxonIdEl = $(document.createElement("taxonId")).text(el.value);
	if (el.provider) {
	$(taxonIdEl).attr("provider", el.provider);
	}
	$(finishedEl).append(taxonIdEl);
	});
	}
	if (classification.taxonomicClassification) {
	_.each(
	classification.taxonomicClassification,
	function (tc) {
	$(finishedEl).append(this.createTaxonomicClassificationDOM(tc));
	},
	this,
	);
	}
	return finishedEl;
	},
	/* Validate this model */
	validate: function () {
	var errors = {};
	if (
	!this.get("generalTaxonomicCoverage") &&
	MetacatUI.appModel.get("emlEditorRequiredFields")
	.generalTaxonomicCoverage
	)
	errors.generalTaxonomicCoverage =
	"Provide a description of the taxonomic coverage.";
	//If there are no taxonomic classifications and it is either required in
	// the AppModel OR a general coverage was given, then require it
	if (
	!this.get("taxonomicClassification").length &&
	(MetacatUI.appModel.get("emlEditorRequiredFields").taxonCoverage ||
	this.get("generalTaxonomicCoverage"))
	) {
	errors.taxonomicClassification =
	"Provide at least one complete taxonomic classification.";
	} else {
	//Every taxonomic classification should be valid
	if (
	!_.every(
	this.get("taxonomicClassification"),
	this.isClassificationValid,
	this,
	)
	)
	errors.taxonomicClassification =
	"Every classification row should have a rank and value.";
	}
	// Check for and remove duplicate classifications
	this.removeDuplicateClassifications();
	if (Object.keys(errors).length) return errors;
	},
	isEmpty: function () {
	return (
	!this.get("generalTaxonomicCoverage") &&
	!this.get("taxonomicClassification").length
	);
	},
	isClassificationValid: function (taxonomicClassification) {
	if (!Object.keys(taxonomicClassification).length) return true;
	if (Array.isArray(taxonomicClassification)) {
	if (
	!taxonomicClassification[0].taxonRankName ||
	!taxonomicClassification[0].taxonRankValue
	) {
	return false;
	}
	} else if (
	!taxonomicClassification.taxonRankName ||
	!taxonomicClassification.taxonRankValue
	) {
	return false;
	}
	if (taxonomicClassification.taxonomicClassification)
	return this.isClassificationValid(
	taxonomicClassification.taxonomicClassification,
	);
	else return true;
	},
	/**
	* Check if two classifications are equal. Two classifications are equal if
	* they have the same rankName, rankValue, commonName, and taxonId, as well
	* as the same nested classifications. This function is recursive.
	* @param {taxonomicClassification} c1
	* @param {taxonomicClassification} c2
	* @returns {boolean} - True if the two classifications are equal
	* @since 2.24.0
	*/
	classificationsAreEqual: function (c1, c2) {
	if (!c1 && !c2) return true;
	if (!c1 && c2) return false;
	if (c1 && !c2) return false;
	// stringify the two classifications for
	const stringKeys = ["taxonRankName", "taxonRankValue", "commonName"];
	// Recursively stringify the nested classifications for comparison
	stringifyClassification = function (c) {
	const stringified = {};
	for (let key of stringKeys) {
	if (c[key]) stringified[key] = c[key];
	}
	if (c.taxonId) stringified.taxonId = c.taxonId;
	if (c.taxonomicClassification) {
	stringified.taxonomicClassification = stringifyClassification(
	c.taxonomicClassification,
	);
	}
	const st = JSON.stringify(stringified);
	// convert all to uppercase for comparison
	return st.toUpperCase();
	};
	return stringifyClassification(c1) === stringifyClassification(c2);
	},
	/**
	* Returns true if the given classification is a duplicate of another
	* classification in this model. Duplicates are considered those that have
	* all values identical, including rankName, rankValue, commonName, and
	* taxonId. If there are any nested classifications, then they too must
	* be identical for the classification to be considered a duplicate, this
	* this function is recursive. Only checks one classification at a time.
	* @param {taxonomicClassification} classification
	* @param {number} indexToSkip - The index of the classification to skip
	* when checking for duplicates. This is useful when checking if a
	* classification is a duplicate of another classification in the same
	* model, but not itself.
	* @returns {boolean} - True if the given classification is a duplicate
	* @since 2.24.0
	*/
	isDuplicate: function (classification, indexToSkip) {
	const classifications = this.get("taxonomicClassification");
	for (let i = 0; i < classifications.length; i++) {
	if (typeof indexToSkip === "number" && i === indexToSkip) continue;
	if (
	this.classificationsAreEqual(classifications[i], classification)
	) {
	return true;
	}
	}
	return false;
	},
	/**
	* Remove any duplicated classifications from this model. See
	* {@link isDuplicate} for more information on what is considered a
	* duplicate. If any classifications are removed, then a
	* "duplicateClassificationsRemoved" event is triggered, passing the
	* removed classifications as an argument.
	* @fires duplicateClassificationsRemoved
	* @since 2.24.0
	*/
	removeDuplicateClassifications: function () {
	const classifications = this.get("taxonomicClassification");
	const removed = [];
	for (let i = 0; i < classifications.length; i++) {
	const classification = classifications[i];
	if (this.isDuplicate(classification, i)) {
	classifications.splice(i, 1);
	this.set("taxonomicClassification", classifications);
	removed.push(classification);
	i--;
	}
	}
	if (removed.length) {
	this.trigger("duplicateClassificationsRemoved", removed);
	}
	},
	/*
	* Climbs up the model hierarchy until it finds the EML model
	*
	* @return {EML211 or false} - Returns the EML 211 Model or false if not
	* found
	*/
	getParentEML: function () {
	var emlModel = this.get("parentModel"),
	tries = 0;
	while (emlModel.type !== "EML" && tries < 6) {
	emlModel = emlModel.get("parentModel");
	tries++;
	}
	if (emlModel && emlModel.type == "EML") return emlModel;
	else return false;
	},
	trickleUpChange: function () {
	MetacatUI.rootDataPackage.packageModel.set("changed", true);
	},
	formatXML: function (xmlString) {
	return DataONEObject.prototype.formatXML.call(this, xmlString);
	},
	},
	);
	return EMLTaxonCoverage;
	});

[github-actions]

🚫 [eslint] <object-shorthand> _{reported by reviewdog 🐶}
Expected method shorthand.

metacatui/src/js/views/metadata/EML211View.js

Lines 2109 to 2136 in a3782ea

	showPubDateValidation: function (e) {
	var container = $(e.target).parents(".pubDate").first(),
	input = $(e.target),
	messageEl = $(container).find(".notification"),
	value = input.val(),
	errors = [];
	// Remove existing error borders and notifications
	input.removeClass("error");
	messageEl.text("");
	messageEl.removeClass("error");
	if (value != "" && value.length > 0) {
	if (!this.isDateFormatValid(value)) {
	errors.push(
	"The value entered for publication date, '" +
	value +
	"' is not a valid value for this field. Enter either a year (e.g. 2017) or a date in the format YYYY-MM-DD.",
	);
	input.addClass("error");
	}
	}
	if (errors.length > 0) {
	messageEl.text(errors[0]).addClass("error");
	}
	},

[github-actions]

🚫 [eslint] <object-shorthand> _{reported by reviewdog 🐶}
Expected method shorthand.

metacatui/src/js/views/metadata/EML211View.js

Lines 2138 to 2149 in a3782ea

	updateRadioButtons: function (e) {
	//Get the element of this radio button set that is checked
	var choice = this.$(
	"[name='" + $(e.target).attr("name") + "']:checked",
	).val();
	if (typeof choice == "undefined" || !choice)
	this.model.set($(e.target).attr("data-category"), "");
	else this.model.set($(e.target).attr("data-category"), choice);
	this.model.trickleUpChange();
	},

[github-actions]

🚫 [eslint] <no-var> _{reported by reviewdog 🐶}
Unexpected var, use let or const instead.

metacatui/src/js/views/metadata/EML211View.js

Lines 2140 to 2142 in a3782ea

	var choice = this.$(
	"[name='" + $(e.target).attr("name") + "']:checked",
	).val();

[github-actions]

🚫 [eslint] <object-shorthand> _{reported by reviewdog 🐶}
Expected method shorthand.

metacatui/src/js/views/metadata/EML211View.js

Lines 2308 to 2424 in a3782ea

	handleRemove: function (e) {
	var submodel = $(e.target).data("submodel"), // Optional sub-model to remove attribute from
	attribute = $(e.target).data("attribute"), // Attribute on the EML211 model we're removing from
	selector = $(e.target).data("selector"), // Selector to find the parent DOM elemente we'll remove
	container = $(e.target).data("container"), // Selector to find the parent container so we can remove by index
	parentEl, // Element we'll remove
	model; // Specific sub-model we're removing
	if (!attribute) return;
	if (!container) return;
	// Find the element we'll remove from the DOM
	if (selector) {
	parentEl = $(e.target).parents(selector).first();
	} else {
	parentEl = $(e.target).parents().first();
	}
	if (parentEl.length == 0) return;
	// Handle remove on a EML model / sub-model
	if (submodel) {
	model = this.model.get(submodel);
	if (!model) return;
	// Get the current value of the attribute so we can remove from it
	var currentValue, submodelIndex;
	if (Array.isArray(this.model.get(submodel))) {
	// Stop now if there's nothing to remove in the first place
	if (this.model.get(submodel).length == 0) return;
	// For multi-valued submodels, find *which* submodel we are removing or
	// removingn from
	submodelIndex = $(container).index(
	$(e.target).parents(container).first(),
	);
	if (submodelIndex === -1) return;
	currentValue = this.model
	.get(submodel)
	[submodelIndex].get(attribute);
	} else {
	currentValue = this.model.get(submodel).get(attribute);
	}
	//FInd the position of this field in the list of fields
	var position = $(e.target)
	.parents(container)
	.first()
	.children(selector)
	.index($(e.target).parents(selector));
	// Remove from the EML Model
	if (position >= 0) {
	if (Array.isArray(this.model.get(submodel))) {
	currentValue.splice(position, 1); // Splice returns the removed members
	this.model
	.get(submodel)
	[submodelIndex].set(attribute, currentValue);
	} else {
	currentValue.splice(position, 1); // Splice returns the removed members
	this.model.get(submodel).set(attribute, currentValue);
	}
	}
	} else if (selector) {
	// Find the index this attribute is in the DOM
	var position = $(e.target)
	.parents(container)
	.first()
	.children(selector)
	.index($(e.target).parents(selector));
	//Remove this index of the array
	var currentValue = this.model.get(attribute);
	if (Array.isArray(currentValue)) currentValue.splice(position, 1);
	//Set the array on the model so the 'set' function is executed
	this.model.set(attribute, currentValue);
	}
	// Handle remove on a basic text field
	else {
	// The DOM order matches the EML model attribute order so we can remove
	// by that
	var position = $(e.target)
	.parents(container)
	.first()
	.children(selector)
	.index(selector);
	var currentValue = this.model.get(attribute);
	// Remove from the EML Model
	if (position >= 0) {
	currentValue.splice(position, 1);
	this.model.set(attribute, currentValue);
	}
	}
	// Trigger a change on the entire package
	MetacatUI.rootDataPackage.packageModel.set("changed", true);
	// Remove the DOM
	$(parentEl).remove();
	//updating the tablesIndex once the element has been removed
	var tableNums = this.$(".editor-header-index");
	for (var i = 0; i < tableNums.length; i++) {
	$(tableNums[i]).text(i + 1);
	}
	// If this was a taxon, update the quickAdd interface
	if (submodel === "taxonCoverage") {
	this.taxaView.updateQuickAddTaxa();
	}
	},

[github-actions]

⚠️ [eslint] <no-console> _{reported by reviewdog 🐶}
Unexpected console statement.

[github-actions]

⚠️ [eslint] <jsdoc/check-types> _{reported by reviewdog 🐶}
Invalid JSDoc @typedef "TaxonomicClassification" type "Object"; prefer: "object".

Suggested change

	/**
	* @name taxonomicClassification
	* @type {Object}
	* @typedef {Object} TaxonomicClassification
	/**
	* @typedef {object} TaxonomicClassification

[github-actions]

⚠️ [eslint] <func-names> _{reported by reviewdog 🐶}
Unexpected unnamed method 'renderTaxa'.

[github-actions]

🚫 [eslint] <object-shorthand> _{reported by reviewdog 🐶}
Expected method shorthand.

Suggested change

	renderTaxa: function () {
	renderTaxa () {

[github-actions]

⚠️ [eslint] <func-names> _{reported by reviewdog 🐶}
Unexpected unnamed method 'updateRadioButtons'.

[github-actions]

🚫 [eslint] <spaced-comment> _{reported by reviewdog 🐶}
Expected exception block, space or tab after '//' in comment.

Suggested change

	//Get the element of this radio button set that is checked
	// Get the element of this radio button set that is checked