Feature-464: HashStore-java Library Import & Junit5 Refactor #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… input stream for sysmeta
…est' method for 'RequestReportJob' when NotAuthorized exception is thrown
…ss name and revise todo items
…hashstore first before mn/cn API
…ling hashstore first before mn/cn API
…quest' for retrieving sysmeta and eml metadata doc streams
…shstore properties through a config file instead of hardcoding
…ata/repos' to metadig-scheduler 'values.yaml'
…r's 'deployment.yaml'
…'getHashStorePropsFromMetadigProps'
…'getSystemMetadataFromHashStoreOrNode'
…'getEMLMetadataDocInputStream'
…'getHashStoreFromMetadigProps'
…igProps' to improve clarity and revise javadoc
…rized' to 'RequestReportJobTest' class
…ks to resolve linting warnings
…o 'RequestReportJobTest' class
…is available, before using the appropriate methods to retrieve system metadata
… and fix existing junit tests affected when renaming methods
…nd 'getHashStoreFromMetadigProps', and fix junit tests
…e in try-catch block, and add logging statements to 'getStorePropsFromMetadigProps'
… 'storeConfig' contains keys required to create a hashstore before attempting to
…using it to retrieve an eml metadata doc
… and fix related junit tests
…d equivalent junit tests
jeanetteclark
requested changes
Feb 3, 2025
Collaborator
jeanetteclark
left a comment
jeanetteclark
left a comment
There was a problem hiding this comment.
looking good - just some pretty minor comments.
src/main/java/edu/ucsb/nceas/mdqengine/scheduler/RequestReportJob.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ucsb/nceas/mdqengine/scheduler/RequestReportJob.java
Outdated
Show resolved
Hide resolved
…and respective section in 'submitReportRequest' to catch and handle these exceptions
…instead of a return value and update junit tests
…xceptions and log them before bubbling them up to be caught, and update junit tests
…uired keys rather than hardcoding into properties, and add new junit test
… to load 'metadig.properties' file from 'helm/metadig-controller' instead
src/main/java/edu/ucsb/nceas/mdqengine/scheduler/RequestReportJob.java
Outdated
Show resolved
Hide resolved
…s before throwing them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes:
submitReportRequestmethod in 'RequestReportJob' class to first try and access an EML metadata document through HashStore before trying the MN/CN APIhashstore-javalibrary, which is used to retrieve a hashstore that is instantiated throughstore.properties found in ametadig.propertiesfile.submitReportRequest