Support data quality checks by integrating hashstore support #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and fix up other minor helm items
…engine into feature-hashstore-support
artntek
requested changes
Mar 11, 2025
src/main/java/edu/ucsb/nceas/mdqengine/dispatch/Dispatcher.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ucsb/nceas/mdqengine/scheduler/AcquireWebResourcesJob.java
Outdated
Show resolved
Hide resolved
src/test/java/edu/ucsb/nceas/mdqengine/dispatch/JavaScriptDispatcherTest.java
Outdated
Show resolved
Hide resolved
src/test/java/edu/ucsb/nceas/mdqengine/dispatch/JavaScriptDispatcherTest.java
Show resolved
Hide resolved
…ge.tag, which will default to appVersion in 'Chart.yaml'
…ault to appVersion in 'Chart.yaml'
…t to appVersion in 'Chart.yaml'
…t to appVersion in 'Chart.yaml'
…ids' method, and wrap section to set these values in a try-catch block to handle a NullPointerException
…ethod, and update error message in 'runSuite' method to include more details
….toString() will throw a NPE by calling String.valueOf() which can handle NPEs
…o IllegalArgumentException to reduce confusion
artntek
requested changes
Mar 24, 2025
Comment on lines
258
to
266
| try { | ||
| nodeIdstring = nodeId.getValue(); | ||
| nodeAbbr = nodeIdstring.replace("urn:node:", ""); | ||
| subjectId = cfg.getString(nodeAbbr + ".subjectId"); | ||
| nodeServiceUrl = cfg.getString(nodeAbbr + ".serviceUrl"); | ||
| } catch (NullPointerException npe) { | ||
| log.error("nodeIdstring and nodeAbbr is null when retrieving data pids for: " | ||
| + identifier); | ||
| } |
Contributor
There was a problem hiding this comment.
it's also not great practice to catch NPEs in code, since it could mask underlying, unanticipated issues. Simpler to use the same pattern you already use elsewhere:
if (nodeId == null) {
throw new MetadigException("nodeId is null.");
}
nodeIdstring = nodeId.getValue();
String nodeAbbr = nodeIdstring.replace("urn:node:", "");
subjectId = cfg.getString(nodeAbbr + ".subjectId");
nodeServiceUrl = cfg.getString(nodeAbbr + ".serviceUrl");
Contributor
There was a problem hiding this comment.
Thank you again for the reminder. This has been updated
…catching NullPointerException
artntek
approved these changes
Mar 24, 2025
doulikecookiedough
approved these changes
Mar 24, 2025
Contributor
doulikecookiedough
left a comment
doulikecookiedough
left a comment
There was a problem hiding this comment.
I have worked with @artntek to resolve comments and to get this PR merged, and also created new issues for items with which I would like your feedback:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates hashstore and does various other minor items to enable data quality checks. Below is a list:
RequestReportJobruns (thanks @doulikecookiedough)getDataPidsmethod and pass resulting pid list to dispatcher