Feature support json #496
Merged
Feature support json #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this still works for XML documents
this makes our tests a little less clunky, and makes more sense logically since it isn't really related to any dialect specific operations
note that ALL of these tests were previously disabled so it isn't as bad as it seems I swear
this is much more streamlined
this is a bug - putting it in the catch block means that no metadata only records will be asssesed. I meant for only metadata only records for the data suite to be skipped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening a new PR since there were some substantial changes from the last one. This version forgoes supporting multiple versions of the schema, and just migrates all documents forward to the most current version. The schema situation is somewhat complicated by this outstanding issue: #492