Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a PostgreSQL Helm chart for deploying PostgreSQL databases on Kubernetes (specifically targeting Spin/NERSC environments). The chart includes standard Kubernetes resources (Deployment, Service, PVC), configuration management through Helm values, and a helper script for rendering configuration templates.
Changes:
- New PostgreSQL Helm chart with templates for deployment, services, PVC, and optional features (ingress, HPA, load balancer)
- Configuration management via values.yaml with placeholder support
- Helper script (prepare-values.sh) to render configuration values
- Documentation and Helm test resources
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| postgresql/Chart.yaml | Chart metadata defining name, version, and PostgreSQL appVersion |
| postgresql/.helmignore | Standard Helm ignore patterns for packaging |
| postgresql/values.yaml | Default configuration with placeholders for deployment-specific values |
| postgresql/prepare-values.sh | Bash script to replace placeholders with actual configuration values |
| postgresql/README.md | Installation and usage documentation |
| postgresql/templates/_helpers.tpl | Helm template helpers for naming and labels |
| postgresql/templates/deployment.yaml | Main Deployment resource for PostgreSQL containers |
| postgresql/templates/service.yaml | ClusterIP Service for database access |
| postgresql/templates/loadbalancer.yaml | Optional LoadBalancer Service |
| postgresql/templates/pvc.yaml | PersistentVolumeClaim template for data storage |
| postgresql/templates/serviceaccount.yaml | ServiceAccount configuration |
| postgresql/templates/ingress.yaml | Optional Ingress resource |
| postgresql/templates/hpa.yaml | Optional HorizontalPodAutoscaler configuration |
| postgresql/templates/tests/test-connection.yaml | Helm test for connectivity verification |
| postgresql/templates/NOTES.txt | Post-installation instructions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: dingp <9438483+dingp@users.noreply.github.com>
[WIP] Update PostgreSQL Helm chart implementation based on feedback
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 15 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…com/NERSC/spin-helm into dingpf/adding_postgresql_helm_chart
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 25 out of 25 changed files in this pull request and generated 10 comments.
Comments suppressed due to low confidence (1)
tls-acme/values_template.yaml:49
- Corrected typo 'ingres' to 'ingress'
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.