Skip to content

Conversation

@BBeltz1
Copy link
Collaborator

@BBeltz1 BBeltz1 commented Jan 2, 2026

  • Update indicator and build package
  • Re-knit comparison document

@BBeltz1 BBeltz1 self-assigned this Jan 2, 2026
Copy link
Contributor

@atyrell3 atyrell3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this matters, but there are two spellings, "All" and "ALL", in the Var column (sentence case seems to be for survey data and all caps for assessment data).

Also, it looks like windowpane flounder survey data didn't have the Jurisdiction assigned correctly, as it is NA but should be NEFMC.

@andybeet
Copy link
Member

andybeet commented Jan 7, 2026

I think @MGrezlik can answer the Windowpane issue

@MGrezlik
Copy link

MGrezlik commented Jan 7, 2026

The Jurisdiction column is added from ecodata::species_groupings here. Windowpane Jurisdiction is 'NA' in that data object when it should be NEFMC

@jcaracappa1
Copy link
Contributor

will it break anything else if we change that species_groupings juristiction for windowpane?

@andybeet
Copy link
Member

andybeet commented Jan 7, 2026

i can't think of anything. i think the most recent script that created that object was in SOE_data repo. Warning: its horrible!

@jcaracappa1
Copy link
Contributor

@MGrezlik can you make that change to SOE_Data and rerunning the plots in this branch to make sure they went through

@MGrezlik
Copy link

MGrezlik commented Jan 8, 2026

@jcaracappa1 @andybeet I think ecodata::species_groupings is created by ecodata::get_species_groupings. Not SOE_data::Create_SOE_species_list. I'm happy to make the edit, just want to confirm before I edit the wrong script

@jcaracappa1
Copy link
Contributor

@jcaracappa1 @andybeet I think ecodata::species_groupings is created by ecodata::get_species_groupings. Not SOE_data::Create_SOE_species_list. I'm happy to make the edit, just want to confirm before I edit the wrong script

Yes that's fine to edit in ecodata

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants