Adding pond ice, prep for new sealvl ponds #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kshedstrom
commented
Oct 25, 2025
kshedstrom
commented
- Not actually calling Icepack ponds yet.
| type(ice_state_type), intent(inout) :: IST !< A type describing the state of the sea ice. | ||
| type(SIS_hor_grid_type), intent(inout) :: G !< G The ocean's grid structure. | ||
| type(ice_grid_type), intent(inout) :: IG !< The sea-ice-specific grid structure. | ||
| real, dimension(SZI_(G),SZJ_(G),SZCAT_(IG)), intent(inout) :: mca_ice !< mass of ice? |
Member
There was a problem hiding this comment.
Please specify the units of all real arguments and internal variables using the same syntax (here it would probably be [R Z ~> kg m-2]) as is used elsewhere in the SIS2 code. This comment applies to many places in ice_pond.F90.
Hallberg-NOAA
requested changes
Jan 17, 2026
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
I have looked through these proposed changes, and they look like a valuable step towards adding pond ice to SIS2. The only thing I would change first is to add some more documentation of the units of real variables (and perhaps some other syntax changes) to align with the SIS2/MOM6 style guide at https://github.com/NOAA-GFDL/MOM6/wiki/Code-style-guide.
- Not actually calling Icepack ponds yet.
Hallberg-NOAA
force-pushed
the
pond_ice
branch
from
8e1b12b to
776a73c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.