fix: Prevent Windows signing service caching stale installers #5587
+27
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a critical issue where the Windows signing step was receiving cached (stale) artifacts from the signing service. This occurred because the signing request used a static filename key (
installer_to_sign.zip) in S3. If a previous build's artifacts remained, the signing client would pick them up instead of the new binary.Fixes
github.shato the zip filename (e.g.,installer_to_sign_<SHA>.zip). This forces the signing service to use a fresh S3 key for every build, bypassing any cache.Testing
Verified that the signing client uses the filename to construct S3 keys. The unique filename ensures isolation between builds.