Skip to content

Couple of small housekeeping changes - fix incorrect return type / default linting rules update. #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
padraic-shafer merged 4 commits into from
Jan 12, 2026
Merged

Couple of small housekeeping changes - fix incorrect return type / default linting rules update. #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4dfadf
Remove incorrect return type.
stuartcampbell Oct 8, 2025
e41e608
Add ruff check for statements in finally (B012)
stuartcampbell Oct 13, 2025
dbf9715
Merge branch 'NSLS2:main' into housekeeping-oct25
stuartcampbell Jan 12, 2026
c93f157
Update target version in pyproject.toml to py312
stuartcampbell Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,4 +67,5 @@ asyncio_mode = "auto"
target-version = "py312"

[tool.ruff.lint]
extend-select = ["I"]
# Catch jump control statements in finally (B012)
extend-select = ["B012","I"]
2 changes: 1 addition & 1 deletion src/nsls2api/exception_handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
# This is to make sure we add the request ID to the response headers for the case
# of unhandled server errors.
@app.exception_handler(Exception)
async def unhandled_exception_handler(request: Request, exc: Exception) -> JSONResponse:
async def unhandled_exception_handler(request: Request, exc: Exception):
return await http_exception_handler(
request,
HTTPException(
Expand Down