Skip to content

ci: Apply save_config_filepath override #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ko3n1g wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

ci: Apply save_config_filepath override #2054

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ac5fca
ci: Apply save_config_filepath override
ko3n1g Jan 24, 2026
e097e87
Merge branch 'main' into ko3n1g/ci/save-config-path
ko3n1g Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion scripts/performance/utils/overrides.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ def _set_common_perf_overrides(recipe: ConfigContainer) -> ConfigContainer:

recipe.logger.log_interval = 1
recipe.logger.tensorboard_dir = None
recipe.logger.save_config_filepath = "/nemo_run/configs/ConfigContainer.yaml"

recipe.ddp.check_for_nan_in_grad = False
recipe.ddp.check_for_large_grads = False
Expand Down Expand Up @@ -239,6 +238,9 @@ def set_user_overrides(recipe: ConfigContainer, args: argparse.Namespace) -> Con
recipe.logger.wandb_exp_name = args.wandb_experiment_name
recipe.logger.wandb_entity = args.wandb_entity_name
recipe.logger.wandb_save_dir = "/nemo_run/wandb"

recipe.logger.save_config_filepath = args.save_config_filepath or "/nemo_run/configs/ConfigContainer.yaml"

if args.max_steps is not None:
recipe.train.train_iters = args.max_steps
if args.tensor_model_parallel_size is not None:
Expand Down