Skip to content

Conversation

@szalpal
Copy link
Member

@szalpal szalpal commented Apr 15, 2025

Category:

New feature (non-breaking change which adds functionality)

Description:

This PR adds support for Python 3.13t. It also adds a test that runs two DALI pipelines at the same time within different threads. Depending on Python version, this will be true parallelism or only concurrency.

At the moment, we need to set PYTHON_GIL=0 environment variable to disable GIL. In future we can omit this by adding py::mod_gil_not_used() to DALI's pybind11 module, however it's better to make sure DALI's working in free-threaded fashion first.

Based on similar PR that adds Python 3.13 support: #5692

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [26991807]: BUILD STARTED

@szalpal szalpal requested a review from Copilot April 15, 2025 14:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds experimental support for Python 3.13t by updating the deprecation warning logic.

  • Updated the comment to clarify behavior for both Python 3.13 and 3.13t.
  • No functional changes beyond updating inline comments for clarity.
Files not reviewed (4)
  • CMakeLists.txt: Language not supported
  • docker/Dockerfile: Language not supported
  • docker/Dockerfile.build.aarch64-linux: Language not supported
  • docker/build_helper.sh: Language not supported

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [26992708]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [27039628]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [27039628]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [27049583]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [27049583]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [27060443]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [27060443]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [27073140]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [27073140]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [27105456]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [27105456]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [27155718]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [27155718]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [27159222]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [27159222]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [27948556]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [27948556]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [27951464]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [27951464]: BUILD PASSED

@szalpal szalpal marked this pull request as ready for review May 7, 2025 08:31
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [28367383]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [28436825]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [28436825]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [28437042]: BUILD STARTED

szalpal added 2 commits May 14, 2025 17:23
Signed-off-by: Michał Szołucha <[email protected]>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [28439370]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [28440001]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [28440380]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [28437042]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [28440380]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [28475734]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [28475734]: BUILD FAILED

Signed-off-by: Michał Szołucha <[email protected]>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [28481985]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [28481985]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [28550627]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [28550627]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [28557015]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [28557015]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [28567578]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [28567578]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [28573473]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [28573473]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [28601272]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [28601272]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [28605189]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [28605189]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [28605189]: BUILD PASSED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants