-
Notifications
You must be signed in to change notification settings - Fork 647
Add experimental support for Python 3.13t #5884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
CI MESSAGE: [26991807]: BUILD STARTED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds experimental support for Python 3.13t by updating the deprecation warning logic.
- Updated the comment to clarify behavior for both Python 3.13 and 3.13t.
- No functional changes beyond updating inline comments for clarity.
Files not reviewed (4)
- CMakeLists.txt: Language not supported
- docker/Dockerfile: Language not supported
- docker/Dockerfile.build.aarch64-linux: Language not supported
- docker/build_helper.sh: Language not supported
|
CI MESSAGE: [26992708]: BUILD STARTED |
|
CI MESSAGE: [27039628]: BUILD STARTED |
|
CI MESSAGE: [27039628]: BUILD FAILED |
|
CI MESSAGE: [27049583]: BUILD STARTED |
|
CI MESSAGE: [27049583]: BUILD FAILED |
|
CI MESSAGE: [27060443]: BUILD STARTED |
|
CI MESSAGE: [27060443]: BUILD FAILED |
|
CI MESSAGE: [27073140]: BUILD STARTED |
|
CI MESSAGE: [27073140]: BUILD FAILED |
|
CI MESSAGE: [27105456]: BUILD STARTED |
|
CI MESSAGE: [27105456]: BUILD FAILED |
|
CI MESSAGE: [27155718]: BUILD STARTED |
|
CI MESSAGE: [27155718]: BUILD FAILED |
|
CI MESSAGE: [27159222]: BUILD STARTED |
|
CI MESSAGE: [27159222]: BUILD FAILED |
Signed-off-by: Michał Szołucha <[email protected]>
|
CI MESSAGE: [27948556]: BUILD STARTED |
|
CI MESSAGE: [27948556]: BUILD FAILED |
|
CI MESSAGE: [27951464]: BUILD STARTED |
|
CI MESSAGE: [27951464]: BUILD PASSED |
|
CI MESSAGE: [28367383]: BUILD FAILED |
|
CI MESSAGE: [28436825]: BUILD STARTED |
|
CI MESSAGE: [28436825]: BUILD FAILED |
|
CI MESSAGE: [28437042]: BUILD STARTED |
Signed-off-by: Michał Szołucha <[email protected]>
Signed-off-by: Michał Szołucha <[email protected]>
|
CI MESSAGE: [28439370]: BUILD STARTED |
|
CI MESSAGE: [28440001]: BUILD STARTED |
|
CI MESSAGE: [28440380]: BUILD STARTED |
|
CI MESSAGE: [28437042]: BUILD FAILED |
|
CI MESSAGE: [28440380]: BUILD FAILED |
|
CI MESSAGE: [28475734]: BUILD STARTED |
|
CI MESSAGE: [28475734]: BUILD FAILED |
Signed-off-by: Michał Szołucha <[email protected]>
|
CI MESSAGE: [28481985]: BUILD STARTED |
|
CI MESSAGE: [28481985]: BUILD FAILED |
|
CI MESSAGE: [28550627]: BUILD STARTED |
|
CI MESSAGE: [28550627]: BUILD FAILED |
|
CI MESSAGE: [28557015]: BUILD STARTED |
|
CI MESSAGE: [28557015]: BUILD FAILED |
|
CI MESSAGE: [28567578]: BUILD STARTED |
|
CI MESSAGE: [28567578]: BUILD FAILED |
|
CI MESSAGE: [28573473]: BUILD STARTED |
|
CI MESSAGE: [28573473]: BUILD FAILED |
|
CI MESSAGE: [28601272]: BUILD STARTED |
|
CI MESSAGE: [28601272]: BUILD FAILED |
|
CI MESSAGE: [28605189]: BUILD STARTED |
|
CI MESSAGE: [28605189]: BUILD FAILED |
|
CI MESSAGE: [28605189]: BUILD PASSED |
Category:
New feature (non-breaking change which adds functionality)
Description:
This PR adds support for Python 3.13t. It also adds a test that runs two DALI pipelines at the same time within different threads. Depending on Python version, this will be true parallelism or only concurrency.
At the moment, we need to set
PYTHON_GIL=0environment variable to disable GIL. In future we can omit this by addingpy::mod_gil_not_used()to DALI's pybind11 module, however it's better to make sure DALI's working in free-threaded fashion first.Based on similar PR that adds Python 3.13 support: #5692
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A