Skip to content

load model to device after creating new action head#294

Merged
youliangtan merged 2 commits intomainfrom
k2/fix-action-head-loading-Issue280
Aug 25, 2025
Merged

load model to device after creating new action head#294
youliangtan merged 2 commits intomainfrom
k2/fix-action-head-loading-Issue280

Conversation

@kaushil24
Copy link
Collaborator

Fixes #280

Changes proposed in this pull request:

  • Moved model load to device after the action head weights are copied

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

Copy link
Member

@youliangtan youliangtan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense!

Signed-off-by: youliangt <youliangt@nvidia.com>
@youliangtan youliangtan merged commit fa4f174 into main Aug 25, 2025
3 checks passed
@youliangtan youliangtan deleted the k2/fix-action-head-loading-Issue280 branch August 25, 2025 20:47
ddebenedittis pushed a commit to Borg-Robotics/Isaac-GR00T that referenced this pull request Oct 7, 2025
* load modle to device after action head weights are copied

* nit

Signed-off-by: youliangt <youliangt@nvidia.com>

---------

Signed-off-by: youliangt <youliangt@nvidia.com>
Co-authored-by: youliangt <youliangt@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

There is an error in the reasoning weight loading code

2 participants