Merged
Conversation
Signed-off-by: choiyj <cyj21c6352@gmail.com>
youliangtan
reviewed
Aug 6, 2025
Member
|
@Choiyoonji Thanks for the contribution! |
ddebenedittis
pushed a commit
to Borg-Robotics/Isaac-GR00T
that referenced
this pull request
Oct 7, 2025
* Add safe globals Signed-off-by: choiyj <cyj21c6352@gmail.com> * Move numpy allowlist to DualBrainTrainer __init__ --------- Signed-off-by: choiyj <cyj21c6352@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #229
Changes proposed in this pull request:
This PR addresses an
_pickle.UnpicklingErrorthat occurs when resuming training usingweights_only=Truewith checkpoints saved in PyTorch 2.1+.Specifically, the following code was added right after
import torchandimport numpy as npin/gr00t/experiment/trainer.py:This change allows PyTorch to safely unpickle RNG state and resume training by explicitly allowlisting required NumPy globals.
Example error message:
Error Reproduction & Test Case
How to reproduce:
Start training and interrupt it manually (e.g., using
Ctrl+C) to generate a checkpoint.Attempt to resume training using the
--resumeflag.You will encounter the following error:
Fix validation:
Float64DType,Int64DType), they can be added to the allowlist in the same way.Reference
Before submitting
section of the
CONTRIBUTINGdocs.