Skip to content

[bug fix] Patch concat transform.#360

Open
xwjiang2010 wants to merge 3 commits intomainfrom
xw/fix_trans
Open

[bug fix] Patch concat transform.#360
xwjiang2010 wants to merge 3 commits intomainfrom
xw/fix_trans

Conversation

@xwjiang2010
Copy link
Collaborator

Fixes #331

Changes proposed in this pull request:

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

@xwjiang2010
Copy link
Collaborator Author

@youliangtan I notice that there is not a lot of test coverage in the repo.
What would be a flow that you suggest that I run manual testing with?

@youliangtan
Copy link
Member

@xwjiang2010 This concat transform patch is helpful, have this been tested e2e?

@maximilianofir
Copy link

I also experience this bug when converting actions from quaternions in the dataset to 6D representation for training.
The error occurs after the conversion, when concatenating the now larger orientation format to the action tensor.
Plus 1 request, to merge the above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why is rotation 6D supported as input representation and not output?

3 participants