-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[None][feat] Support DeepGEMM swap-AB on sm100 #7355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughUpdates Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Caller
participant Op as fp8_swap_ab_gemm
participant NT as fp8_gemm_nt
participant NTT as fp8_gemm_ntt
Caller->>Op: forward(A, B, tactic)
alt tactic == 1 (swap AB)
Note right of Op #f0f4ff: swap_ab = true
Op->>NTT: compute with AB-swapped kernel
NTT-->>Op: result
else tactic == 0 (no swap)
Note right of Op #f0f4ff: swap_ab = false
Op->>NT: compute with standard kernel
NT-->>Op: result
end
Op-->>Caller: output
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
250e268
to
10fc27f
Compare
/bot run |
PR_Github #16935 [ run ] triggered by Bot |
PR_Github #16935 [ run ] completed with state |
Signed-off-by: Barry Kang <[email protected]>
10fc27f
to
165bf39
Compare
/bot run |
PR_Github #16953 [ run ] triggered by Bot |
PR_Github #16953 [ run ] completed with state |
This PR enables swap AB as an optional tactic for sm100 FP8 blockwise GEMM.
Summary by CodeRabbit
New Features
Chores