Skip to content

A FasterRMSNorm implementation (based on FasterLayerNorm) #1688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

A FasterRMSNorm implementation (based on FasterLayerNorm) #1688

wants to merge 2 commits into from

Conversation

Njuapp
Copy link

@Njuapp Njuapp commented Jun 30, 2023

A FasterRMSNorm implementation (similar to FasterLayerNorm).

crcrpar
crcrpar requested changes Jul 7, 2023
View reviewed changes
apex/contrib/test/layer_norm/test_fast_rms_norm.py
)
)

def _test_impl(S, B, hidden_size, itype, wtype, ctype=fp32):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this test is based on the existing one for faster layer norm but could you access the following two items?

  1. make this function a member method of the test class below
  2. use torch.testing.assert_close instead of check_err and TestFastRMSNorm.assertAll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crcrpar crcrpar crcrpar requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Njuapp @crcrpar