Remove pickle, minor variable rename #1924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing pickle usage to avoid security issue.
Aidyn-A
approved these changes
Aug 11, 2025
Comment on lines
67
to
70
| cache_dir_path = ASP_CACHE_DIR_DEFAULT | ||
| # The user is allowed to set the cache directory via an environment variable. | ||
| if environ.get(ASP_CACHE_DIR_ENV_VAR) is not None: | ||
| cache_dir_path = environ.get(ASP_CACHE_DIR_ENV_VAR) |
There was a problem hiding this comment.
Overall looks good to me. I would also recommend to use getenv instead of environ.get to reduce lines.
Suggested change
| cache_dir_path = ASP_CACHE_DIR_DEFAULT | |
| # The user is allowed to set the cache directory via an environment variable. | |
| if environ.get(ASP_CACHE_DIR_ENV_VAR) is not None: | |
| cache_dir_path = environ.get(ASP_CACHE_DIR_ENV_VAR) | |
| cache_dir_path = os.getenv(ASP_CACHE_DIR_ENV_VAR, ASP_CACHE_DIR_DEFAULT) |
crcrpar
approved these changes
Aug 12, 2025
|
Merging based on reviewer comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing pickle usage to avoid security issue.