Skip to content

Disable public docs features in PR previews - #8568

Open
csadorf wants to merge 1 commit into
NVIDIA:mainfrom
csadorf:fix/public-docs-pr-previews
Open

Disable public docs features in PR previews#8568
csadorf wants to merge 1 commit into
NVIDIA:mainfrom
csadorf:fix/public-docs-pr-previews

Conversation

@csadorf

@csadorf csadorf commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Disables public_docs_features when RAPIDS_BUILD_TYPE=pull-request, while keeping them enabled for nightly and release documentation builds.

Follow-up to #8533

@csadorf
csadorf requested a review from a team as a code owner September 8, 2026 13:04
@csadorf
csadorf requested a review from betatim September 8, 2026 13:04
@csadorf csadorf added bug Something isn't working non-breaking Non-breaking change labels Sep 8, 2026
@csadorf csadorf added bug Something isn't working and removed bug Something isn't working labels Sep 8, 2026
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: fa59277a-a76c-4c1d-9125-e535047320b7

📥 Commits

Reviewing files that changed from the base of the PR and between b07de6e and 2423130.

📒 Files selected for processing (1)
  • docs/source/conf.py

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Documentation
    • HTML documentation features are now enabled for CI builds outside pull requests and disabled for pull-request builds.

Walkthrough

The documentation configuration now enables public_docs_features only for CI builds that are not pull-request builds.

Changes

Documentation feature gating

Layer / File(s) Summary
CI feature gate
docs/source/conf.py
public_docs_features requires CI to equal "true" and RAPIDS_BUILD_TYPE to differ from "pull-request".

Priority: ⬇️ Low — Defer this documentation configuration change because it only adjusts public documentation features in pull-request previews, with no broader product impact indicated.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 24231

Pull-request documentation previews no longer enable public documentation features, while nightly and release CI documentation builds retain them. No current merge-blocking risk remains.

Suggested reviewers: bdice, jcrist

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description accurately explains that public_docs_features is disabled for pull-request builds and remains enabled for nightly and release builds.
Title check ✅ Passed The title clearly and concisely states the main change: disabling public documentation features in pull-request previews.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants