Add annotations support to DCGM Exporter service configuration #1642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronaldosaheki
requested review from
ArangoGutierrez,
cdesiniotis,
elezar,
shivamerla and
tariq1890
as code owners
- Introduced an `Annotations` field in `DCGMExporterServiceConfig` to allow custom annotations for the DCGM Exporter service. - Updated the deepcopy function to handle the new `Annotations` field. - Modified the service transformation logic to apply specified annotations to the DCGM Exporter service. - Enhanced the CRD definition to include the new annotations property. - Added unit tests to verify the correct application of annotations in various scenarios. Signed-off-by: Ronaldo Saheki <[email protected]>
ronaldosaheki
force-pushed
the
add-dcgemexporter-service-annotations
branch
from
0a50b0f to
67c592f
Compare
- Enhanced the CRD definitions for both `nvidia.com_clusterpolicies.yaml` files to include an `annotations` field. - This new field allows users to specify custom annotations for the DCGM Exporter service. Signed-off-by: Ronaldo Saheki <[email protected]>
ronaldosaheki
changed the title
ronaldosaheki
changed the title
codeartctz
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently DCGM exports metrics to port 9400, but prometheus default is 9090 and is missing annotation:
Changes:
Annotationsfield inDCGMExporterServiceConfigto allow custom annotations for the DCGM Exporter service.