Skip to content

Adding support for hostpath on NIMService #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2025
Merged

Adding support for hostpath on NIMService #699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f162148
Adding support for hostpath on NIMService
visheshtanksale Oct 31, 2025
f2e279c
Adding OCP security context
visheshtanksale Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 36 additions & 4 deletions api/apps/v1alpha1/nimservice_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,6 +499,8 @@ func (n *NIMService) GetStandardAnnotations() map[string]string {
}
if n.GetProxyCertConfigMap() != "" {
standardAnnotations["openshift.io/required-scc"] = "anyuid"
} else if n.GetHostPath() != "" {
standardAnnotations["openshift.io/required-scc"] = "hostmount-anyuid"
}
return standardAnnotations
}
Expand Down Expand Up @@ -709,7 +711,8 @@ func (n *NIMService) GetVolumes(modelPVC *PersistentVolumeClaim) []corev1.Volume
},
},
}
if modelPVC != nil {
switch {
case modelPVC != nil:
volumes = append(volumes, corev1.Volume{
Name: "model-store",
VolumeSource: corev1.VolumeSource{
Expand All @@ -719,7 +722,7 @@ func (n *NIMService) GetVolumes(modelPVC *PersistentVolumeClaim) []corev1.Volume
},
},
})
} else if n.Spec.Storage.EmptyDir != nil {
case n.Spec.Storage.EmptyDir != nil:
volumes = append(volumes, corev1.Volume{
Name: "model-store",
VolumeSource: corev1.VolumeSource{
Expand All @@ -728,6 +731,17 @@ func (n *NIMService) GetVolumes(modelPVC *PersistentVolumeClaim) []corev1.Volume
},
},
})
case n.GetHostPath() != "":
hostPathType := corev1.HostPathDirectoryOrCreate
volumes = append(volumes, corev1.Volume{
Name: "model-store",
VolumeSource: corev1.VolumeSource{
HostPath: &corev1.HostPathVolumeSource{
Path: *n.Spec.Storage.HostPath,
Type: &hostPathType,
},
},
})
}

if n.GetProxyCertConfigMap() != "" {
Expand Down Expand Up @@ -1417,7 +1431,8 @@ func (n *NIMService) GetRoleParams() *rendertypes.RoleParams {
params.Namespace = n.GetNamespace()

// Set rules to use SCC
if n.GetProxySpec() != nil {
switch {
case n.GetProxySpec() != nil:
params.Rules = []rbacv1.PolicyRule{
{
APIGroups: []string{"security.openshift.io"},
Expand All @@ -1426,7 +1441,16 @@ func (n *NIMService) GetRoleParams() *rendertypes.RoleParams {
Verbs: []string{"use"},
},
}
} else {
case n.GetHostPath() != "":
params.Rules = []rbacv1.PolicyRule{
{
APIGroups: []string{"security.openshift.io"},
Resources: []string{"securitycontextconstraints"},
ResourceNames: []string{"hostmount-anyuid"},
Verbs: []string{"use"},
},
}
default:
params.Rules = []rbacv1.PolicyRule{
{
APIGroups: []string{"security.openshift.io"},
Expand Down Expand Up @@ -1591,6 +1615,14 @@ func (n *NIMService) GetProxyCertConfigMap() string {
return ""
}

// GetHostPath returns the host path for the NIMService deployment.
func (n *NIMService) GetHostPath() string {
if n.Spec.Storage.HostPath != nil && *n.Spec.Storage.HostPath != "" {
return *n.Spec.Storage.HostPath
}
return ""
}

// GetInferenceServiceParams returns params to render InferenceService from templates.
func (n *NIMService) GetInferenceServiceParams(
deploymentMode kserveconstants.DeploymentModeType) *rendertypes.InferenceServiceParams {
Expand Down
6 changes: 4 additions & 2 deletions internal/controller/platform/kserve/nimservice.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,9 +342,11 @@ func (r *NIMServiceReconciler) renderAndSyncCache(ctx context.Context,
modelPVC = &nimService.Spec.Storage.PVC
} else if nimService.Spec.Storage.EmptyDir != nil {
modelPVC = nil
} else if nimService.Spec.Storage.HostPath != nil && *nimService.Spec.Storage.HostPath != "" {
modelPVC = nil
} else {
err := fmt.Errorf("neither external PVC name or NIMCache volume is provided")
logger.Error(err, "failed to determine PVC for model-store")
err := fmt.Errorf("neither external PVC name, NIMCache volume, empty dir or local host path should be provided")
logger.Error(err, "failed to determine PVC , NIMCache volume, empty dir or local host path for model-store")
return nil, "", nil, err
}

Expand Down
6 changes: 4 additions & 2 deletions internal/controller/platform/standalone/nimservice.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,9 +372,11 @@ func (r *NIMServiceReconciler) reconcileNIMService(ctx context.Context, nimServi
modelPVC = &nimService.Spec.Storage.PVC
} else if nimService.Spec.Storage.EmptyDir != nil {
modelPVC = nil
} else if nimService.Spec.Storage.HostPath != nil && *nimService.Spec.Storage.HostPath != "" {
modelPVC = nil
} else {
err = fmt.Errorf("neither external PVC name, NIMCache volume or empty dir is provided")
logger.Error(err, "failed to determine PVC , NIMCache volume or empty dir for model-store")
err = fmt.Errorf("neither external PVC name, NIMCache volume, empty dir or local host path should be provided")
logger.Error(err, "failed to determine PVC , NIMCache volume, empty dir or local host path for model-store")
return ctrl.Result{}, err
}

Expand Down
Loading