Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves config deserialization diagnostics by replacing OneOrMany<T>’s derived Serde behavior with a custom Deserialize implementation that preserves inner T deserialization errors, and adds unit tests to validate the improved error messages.
Changes:
- Implement a custom
serde::de::Visitor+DeserializeforOneOrMany<T>to propagate inner errors. - Remove derived
Deserialize/#[serde(untagged)]usage in favor of the custom deserializer. - Add unit tests covering single vs many cases and error-message propagation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nreinicke
approved these changes
Mar 27, 2026
Collaborator
nreinicke
left a comment
There was a problem hiding this comment.
This all makes sense to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR addresses a limitation in the OneOrMany type during deserialization errors. if the inner type T fails to deserialize, the OneOrMany deserialization error gobbles up the inner error message and only returns (for, in this case, a config file named
config_file.toml):which is the default deserialization error of an
#[serde(untagged)] enum. this PR implements a custom deserializer that will not fail to propagate the inner error message. tests are added that demonstrate the improvement.