Refactor TLS Remote (Peer) Certification Verification for ECDH Demo #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…validation visibility
…network name as SAN, if necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pull request #189, the kmyth ECDH demonstration code was changed to require a specific format for the name used in server certificate verification (i.e., network host name or IP address concatenated, using '.' as the separator, with a unique name to indicate functionality). This was done to address issues with implementing all of the ECDH demo nodes on the same network host (i.e., localhost).
This pull request attempts to propose a better approach. Instead of parsing the network (connection) host name and the certificate verification criteria from a custom format, it provides options for the user to directly specify the network host name/IP and, optionally, a separate Subject Alternative Name (SAN) criteria to be used in name verification for the remote (peer) certificate. This is hopefully simpler, less confusing, and more generic than the current approach.