Skip to content

fix: inner type should not be set when companion object is defined as a property on constructor #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2025
Merged

fix: inner type should not be set when companion object is defined as a property on constructor #1831

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26f7cce
fix: inner type should net be set when companion object is defined as…
ammarahm-ed Feb 19, 2025
94a4f7f
Merge branch 'main' into fix-inner-types
NathanWalker Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions test-app/runtime/src/main/cpp/MetadataNode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,11 +859,15 @@ void MetadataNode::SetInnerTypes(v8::Isolate* isolate, Local<Function>& ctorFunc
auto context = isolate->GetCurrentContext();
const auto &children = *treeNode->children;
for (auto curChild: children) {
ctorFunction->SetAccessor(
context,
v8::String::NewFromUtf8(isolate, curChild->name.c_str()).ToLocalChecked(),
InnerTypeAccessorGetterCallback, nullptr, v8::External::New(isolate, curChild)
);
bool hasOwnProperty = ctorFunction->HasOwnProperty(context, ArgConverter::ConvertToV8String(isolate, curChild->name)).ToChecked();
// Child is defined as a function already when the inner type is a companion object
if (!hasOwnProperty) {
ctorFunction->SetAccessor(
context,
v8::String::NewFromUtf8(isolate, curChild->name.c_str()).ToLocalChecked(),
InnerTypeAccessorGetterCallback, nullptr, v8::External::New(isolate, curChild)
);
}
}
}
}
Expand Down
Loading