Ingestion + caching fixes - #245
Merged
Merged
Conversation
Added as a post_run() method to the Task class because it applies to all of them currently, but should be able to be overridden if necessary.
Disables the check against the previous file hash, meaning the file will be reingested even if it's the same as the previous version. This shouldn't generally be needed, but is useful for handling ingest errors where the same file may need to be re-parsed.
Fixes an issue introduced in ba0a3dc where identically named methods from IPackageController and IResourceController were both used, meaning the IResourceController methods were being ignored. This renames the methods for 2.10+ compatibility, and makes the old names handle both interfaces (not ideal, but we still need to support 2.9).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes:
clear-cachecommandreingestflag for ingest task, which ignores the previous file hash and reads the file even if it's already been read (or at least, it thinks it has, which is what this is for); should probably only be used withreplace = Truebut I haven't enforced thatFixing the bug from ba0a3dc will also require identifying and ingesting any resources that should have been ingested while it was live.