Skip to content

add get, find#243

Merged
AndrewSRP merged 11 commits intomainfrom
feat/68
May 22, 2025
Merged

add get, find#243
AndrewSRP merged 11 commits intomainfrom
feat/68

Conversation

@AndrewSRP
Copy link
Copy Markdown
Contributor

@AndrewSRP AndrewSRP commented Apr 14, 2025

This resolves

@AndrewSRP AndrewSRP self-assigned this Apr 14, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 14, 2025

✅ All utility modules are properly registered in index.ts and package.json exports!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 14, 2025

Benchmark Results

Method Test Performance Comparison hidash ops/sec lodash@4.17.21 ops/sec
find src/find.bench.ts > find performance hidash is 3.89x faster 1534.35 🏆 394.89
get src/get.bench.ts > get performance hidash is 3.26x faster 1109.36 🏆 340.28

Note: Higher operations per second (ops/sec) numbers are better. Each test compares hidash vs lodash implementation.

⚠️ indicates where hidash is slower than lodash.

🏆 indicates the faster implementation.

View Full Benchmark Data
{
  "files": [
    {
      "filepath": "/home/runner/work/hidash/hidash/src/find.bench.ts",
      "groups": [
        {
          "fullName": "src/find.bench.ts > find performance",
          "benchmarks": [
            {
              "id": "-2037859673_0_0",
              "name": "hidash",
              "rank": 1,
              "rme": 0.3900097515842264,
              "samples": [],
              "totalTime": 500.5389289999982,
              "min": 0.6121949999999288,
              "max": 1.067166000000043,
              "hz": 1534.3461926814543,
              "period": 0.6517433971354143,
              "mean": 0.6517433971354143,
              "variance": 0.0012916751050479904,
              "sd": 0.03593988181739042,
              "sem": 0.001296868777619606,
              "df": 767,
              "critical": 1.96,
              "moe": 0.0025418628041344276,
              "p75": 0.6829680000000735,
              "p99": 0.7397230000000263,
              "p995": 0.7714619999999854,
              "p999": 1.067166000000043,
              "sampleCount": 768,
              "median": 0.6377930000000163
            },
            {
              "id": "-2037859673_0_1",
              "name": "lodash",
              "rank": 2,
              "rme": 1.283290418411396,
              "samples": [],
              "totalTime": 501.40107399999897,
              "min": 2.4418969999999263,
              "max": 4.477460000000065,
              "hz": 394.893450108566,
              "period": 2.5323286565656513,
              "mean": 2.5323286565656513,
              "variance": 0.05443059604312111,
              "sd": 0.23330365630036987,
              "sem": 0.016580168883873994,
              "df": 197,
              "critical": 1.96,
              "moe": 0.03249713101239303,
              "p75": 2.5378769999999804,
              "p99": 4.3003230000000485,
              "p995": 4.477460000000065,
              "p999": 4.477460000000065,
              "sampleCount": 198,
              "median": 2.4906684999999698
            }
          ]
        }
      ]
    },
    {
      "filepath": "/home/runner/work/hidash/hidash/src/get.bench.ts",
      "groups": [
        {
          "fullName": "src/get.bench.ts > get performance",
          "benchmarks": [
            {
              "id": "196551904_0_0",
              "name": "hidash",
              "rank": 1,
              "rme": 0.23087090387179224,
              "samples": [],
              "totalTime": 500.28911399999987,
              "min": 0.8714800000000196,
              "max": 1.122760000000028,
              "hz": 1109.3585378313871,
              "period": 0.9014218270270268,
              "mean": 0.9014218270270268,
              "variance": 0.0006257133004105705,
              "sd": 0.02501426194015267,
              "sem": 0.001061796285589245,
              "df": 554,
              "critical": 1.96,
              "moe": 0.0020811207197549203,
              "p75": 0.8984800000000064,
              "p99": 1.0161110000000235,
              "p995": 1.0613549999999918,
              "p999": 1.122760000000028,
              "sampleCount": 555,
              "median": 0.8956749999999829
            },
            {
              "id": "196551904_0_1",
              "name": "lodash",
              "rank": 2,
              "rme": 0.20101320239237272,
              "samples": [],
              "totalTime": 502.5336180000014,
              "min": 2.8900449999998727,
              "max": 3.1677049999999554,
              "hz": 340.27574250763763,
              "period": 2.9387930877193065,
              "mean": 2.9387930877193065,
              "variance": 0.0015533565462917006,
              "sd": 0.039412644497568296,
              "sem": 0.0030139602537297295,
              "df": 170,
              "critical": 1.96,
              "moe": 0.005907362097310269,
              "p75": 2.9528229999999667,
              "p99": 3.1334099999999125,
              "p995": 3.1677049999999554,
              "p999": 3.1677049999999554,
              "sampleCount": 171,
              "median": 2.9243589999998676
            }
          ]
        }
      ]
    }
  ]
}

Last updated by GitHub Actions

@npayfebot
Copy link
Copy Markdown
Collaborator

npayfebot commented Apr 14, 2025

✅ Changeset detected

Latest commit: 0291a8e

@naverpay/hidash package have detected changes.

If no version change is needed, please add skip-detect-change to the label.

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@naverpay/hidash ✨ Minor
powered by: naverpay changeset detect-add actions

@yceffort-naver
Copy link
Copy Markdown
Contributor

draft 풀어주시면보겠습니다!

@yujeong-jeon
Copy link
Copy Markdown
Contributor

yujeong-jeon commented Apr 28, 2025

@AndrewSRP According to #165 , patterns like 'a.b.c' and 'arr[4][0]' were removed from hidash. Please consider it when implementing the function. :)

Relevant PR: #228

@AndrewSRP
Copy link
Copy Markdown
Contributor Author

AndrewSRP commented May 8, 2025

@yujeong-jeon thank you for comment.
I will check excluding patterns like 'a.b.c' and 'are[4][0]'
and change ready for review

@AndrewSRP AndrewSRP changed the title add get add get, find May 9, 2025
@AndrewSRP AndrewSRP marked this pull request as ready for review May 9, 2025 07:50
@AndrewSRP AndrewSRP requested a review from a team as a code owner May 9, 2025 07:50
Copy link
Copy Markdown
Contributor

@yujeong-jeon yujeong-jeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add comments to the function you added according to the commenting guideline?

https://github.com/NaverPayDev/hidash?tab=readme-ov-file#commenting-guidelines

Comment thread src/get.bench.ts Outdated
Copy link
Copy Markdown
Contributor

@yujeong-jeon yujeong-jeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the unused codes in get.test.ts. I would like to ask if it can be removed.

@AndrewSRP
Copy link
Copy Markdown
Contributor Author

thank you for comments

Could you please add comments to the function you added according to the commenting guideline?

write comment at f7f0803

I see the unused codes in get.test.ts. I would like to ask if it can be removed.

remmoved the unused codes at 94a386d

Comment thread .changeset/mean-turtles-remain.md Outdated
Copy link
Copy Markdown
Contributor

@yujeong-jeon yujeong-jeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍 👍 LGTM~!

@AndrewSRP AndrewSRP merged commit ec2e179 into main May 22, 2025
6 checks passed
@AndrewSRP AndrewSRP deleted the feat/68 branch May 22, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants