[react-pdf] Promise.withResolvers 추가 #208
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Changeset detectedLatest commit: d9c7c06
If no version change is needed, please add The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
|
Contributor
|
여기 배포 세팅안했던거같은데 |
Collaborator
NPM Packages📦 @naverpay/react-pdfTotal Sizes: 22 kB Total Changes: +69 B (0%)
ℹ️ View Unchanged Files
powered by: naverpay size-action |
Contributor
Author
|
바로 리얼배포 들어가보겠습니다 |
| @@ -1,3 +1,7 @@ | |||
| // pdfjs-dist에서 Promise.withResolvers를 사용하므로 polyfill 주입을 위해 호출 | |||
| // eslint-disable-next-line @typescript-eslint/no-unused-expressions | |||
| Promise.withResolvers | |||
Contributor
There was a problem hiding this comment.
// polyfill 바닐라로 구현해서 넣기
if (typeof Promise.withResolvers !== 'function') {
Promise.withResolvers = function <T>() {
let resolve: (value: T | PromiseLike<T>) => void
let reject: (reason?: unknown) => void
const promise = new Promise<T>((res, rej) => {
resolve = res
reject = rej
})
return { promise, resolve: resolve!, reject: reject! }
}
}import 'core-js/actual/promise/with-resolvers'https://app.unpkg.com/[email protected]/files/actual/promise/with-resolvers.js
둘중 하나가 맞을듯..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Describe your changes
Promise.withResolvers 폴리필 주입을 위한 코드 추가
ios특정버전 미만에서(16.6.1 버전이상에서는 정상동작 확인) react-pdf 에러가 발생하는 문제의 원인으로 추정중. (테스트 필요)
Request