Adding Near -> Eth connectors#99
Merged
Merged
Conversation
added tests for BridgeToken lack of tests for BridgeTokenFactory - will be added in next commits
…n/rainbow-token-connector into near-eth-connectors
sept-en
suggested changes
Apr 1, 2022
Co-authored-by: Kirill <gammerxpower@gmail.com>
Contributor
Author
|
I didn't update to near-plugins because versions of dependencies don't match. I suggest to do that in a separate PR otherwise, this going to be a huge mess as it needs all changes from #96 |
mfornet
reviewed
Apr 4, 2022
mfornet
left a comment
mfornet
left a comment
Contributor
There was a problem hiding this comment.
Looks good security wise.
Contributor
|
Last update - I cut some errors just to get some space. Is it ok? |
Co-authored-by: Kirill <gammerxpower@gmail.com>
Co-authored-by: Kirill <gammerxpower@gmail.com>
Contributor
No, please revert. |
This reverts commit 5a77538.
Contributor
|
Reverted |
Shockedshodan
force-pushed
the
near-eth-connectors
branch
from
e4b3ee6 to
2496b3f
Compare
sept-en
approved these changes
Aug 10, 2022
sept-en
left a comment
sept-en
left a comment
Contributor
There was a problem hiding this comment.
Merging it now. All future improvements should be done in separate PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two new connectors are added:
token-factory- locks NEP141 tokens on NEAR side and emits<token, amount, recipient address>. AcceptsUnlockevent from Ethereum side, verifies it's correctness and releases funds to it.erc20-bridge-token-BridgeTokenFactoryandBridgeTokenEthereum contracts.BridgeTokenFactorycreates newBridgeTokenthat correspond to specific token account id on NEAR side.BridgeTokenFactorycan receive events from NEAR, verify them and mint appropriate amounts on recipient addresses. Callingwithdrawwill burn tokens of this user and will generate event<>that can be relayed totoken-factory.