Feature/other timing notifications#81
Merged
Merged
Conversation
…generics, add channel name
- New /settings/otherReminders page with 3 sections (Morning, Night, Fasting) - Replaced inline toggles with SettingsItem link in notification settings - System default sound (null) instead of tasbih - Section descriptions explain timing calculations
initializeTodayData could race with initializeStore's AthkarDB.initialize(), causing DB queries to fail silently and leaving currentProgress empty. Cache the init promise (same pattern as openDatabase) so all callers share the same initialization, and await it in initializeTodayData.
- Use expo-file-system Paths objects instead of getDirectory() for file operations — fixes "URI is not absolute" crash on Android where SQLite.defaultDatabaseDirectory returns a plain path, not a file:// URI - Update all tamagui packages from 2.0.0-rc.25 to 2.0.0-rc.34 — fixes Sheet applying animated styles to non-animated components (Reanimated error)
Users can now choose their preferred Duha reminder time using inline pill selectors constrained to the valid Duha window (Ishraq→Dhuhr). Hours scroll horizontally, minutes fill the row evenly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.