Tarea #2144 - Añadir filtros al agrupar documentos.#1339
Tarea #2144 - Añadir filtros al agrupar documentos.#1339daniel89fg wants to merge 12 commits intoNeoRazorX:masterfrom
Conversation
# Conflicts: # Core/Controller/DocumentStitcher.php # Core/View/DocumentStitcher.html.twig
# Conflicts: # Core/Controller/DocumentStitcher.php # Core/View/DocumentStitcher.html.twig
… into 2144_filtros_agrupar_documentos # Conflicts: # Core/View/DocumentStitcher.html.twig
abdedarghal111
left a comment
abdedarghal111
left a comment
There was a problem hiding this comment.
Parece estar okey
There was a problem hiding this comment.
Pull request overview
This pull request adds filtering functionality to the document grouping feature (DocumentStitcher). It introduces filters for payment methods and dates, allowing users to narrow down the list of available documents when grouping or splitting them. The implementation adds a collapsible filter section in the UI and modifies the backend to handle filter processing.
Changes:
- Added filter support to DocumentStitcher controller with payment method and date filters
- Modified the template to display filters in a collapsible section with separate search and add forms
- Updated FormasPago data source to support filtering by company (incomplete/broken implementation)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 12 comments.
| File | Description |
|---|---|
| Core/Controller/DocumentStitcher.php | Added filter properties, methods to initialize filters (addFilters) and process filter requests (processFormDataLoad) |
| Core/View/DocumentStitcher.html.twig | Restructured the "more documents" section to include a filter form and separate search/add actions |
| Core/DataSrc/FormasPago.php | Attempted to add company filtering to payment methods (broken implementation with undefined variables) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| foreach ($this->filters as $filter) { | ||
| $filter->setValueFromRequest($this->request); | ||
| if ($filter->getDataBaseWhere($this->where)) { | ||
| $this->showFilters = true; |
There was a problem hiding this comment.
The property $showFilters is used in the template and set on line 459, but it's not declared as a class property. Add a public property declaration for $showFilters in the class definition (around lines 45-64) to avoid undefined property warnings.
Se actualiza el método addFilters en DocumentStitcher para que utilice todos los métodos de pago disponibles en lugar de solo los que tienen un código específico. Además, se ajusta la forma en que se almacenan los métodos de pago en el filtro.
Tarea #2144
¿Cómo has probado los cambios?
Toda modificación debe haber sido mínimamente probada. Marca o describe las pruebas que has realizado: