Añadir documentación sobre el manejo de bloques en el MailNotifier y …#1797
Merged
NeoRazorX merged 2 commits intoNeoRazorX:masterfrom Sep 26, 2025
Merged
Añadir documentación sobre el manejo de bloques en el MailNotifier y …#1797NeoRazorX merged 2 commits intoNeoRazorX:masterfrom
NeoRazorX merged 2 commits intoNeoRazorX:masterfrom
Conversation
…comentar la adición de adjuntos.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds documentation and makes adjustments to the MailNotifier class to improve code clarity and understanding. The changes focus on documenting how blocks are handled in email notifications and temporarily commenting out attachment functionality.
- Added comprehensive documentation explaining block handling mechanism
- Commented out attachment addition functionality
- Minor comment formatting improvement
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Core/Lib/Email/MailNotifier.php
Outdated
|
|
||
| foreach ($attach as $adjunto) { | ||
| $newMail->addAttachment($adjunto, basename($adjunto)); | ||
| //$newMail->addAttachment($adjunto, basename($adjunto)); |
There was a problem hiding this comment.
Commented-out code should be removed rather than left in the codebase. If this functionality needs to be temporarily disabled, consider using a feature flag or configuration option instead.
Suggested change
| //$newMail->addAttachment($adjunto, basename($adjunto)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…comentar la adición de adjuntos.
¿Cómo has probado los cambios?
Toda modificación debe haber sido mínimamente probada. Marca o describe las pruebas que has realizado: