Conversation
…dores para que quepan todos los valores de RegimenIVA. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add missing `use RegimenIVA` in Calculator that would cause a fatal error. Simplify E3 (art. 22) and E4 (arts. 23-24) validations in CalculatorModSpain to always reject IVA > 0, consistent with E1 and E6, removing confusing country/NIF conditions that contradicted the warning messages. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… document models - Correct recargo de equivalencia logic: apply RE based on customer regime for sales and company regime for purchases - Add calculateLine() to CalculatorModSpain to enforce recargo rules early when creating new document lines - Add calculateLine() call in PurchaseDocument::getNewProductLine() and skip duplicate call in getNewLine() when called from getNewProductLine() - Add intra-community subcuentas (4721/4771) to Impuesto model and accounting entries in InvoiceToAccounting - Add excepcioniva field to EditImpuestoZona.xml with exception list loading - Add CSV delimiter fallback when ParseCsv auto-detection fails - Update ESP default plan with 6 new intra-community subaccounts - Fix related tests for new RE behavior and intra-community accounting Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove unnecessary & on object params (BusinessDocument, BusinessDocumentLine) for consistency with CalculatorModClass. Add missing RegimenIVA import. Add unit tests for Spanish tax operations: intra-community, reverse charge, export, import, gold, REAGYP, used goods (REBU) and travel agency. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Change retention icon to fa-minus-circle to differentiate from taxes. Add sorting options to ListImpuesto (vat, surcharge, percentage). Reorganize EditImpuesto columns and separate accounting subaccounts into their own group. Adjust EditRetencion column widths. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fix applyUsedGoods and applyTravel: neto was set to totalCoste instead of pvpTotal when margin was negative, causing wrong document totals. Now always accumulate margin in neto and only apply IVA when margin is positive or serie is rectificativa. Move 4 Spain-specific tests from CalculatorTest to CalculatorModSpainTest and add 9 new tests: negative margin (REBU and travel, normal and rectificativa), export on purchase, import on sale, REBU with normal product, travel agency purchase, intra-community purchase with multiple rates. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add allForPurchases() and allForSales() methods to InvoiceOperation so that only relevant operations are shown in each context: export, successive tract and work certification for sales only; import for purchases only; the rest for both. Update EditCliente, EditProveedor and CommonSalesPurchases to use the filtered methods. Add unit test. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descripción
Description (english)
¿Cómo has probado los cambios?
Toda modificación debe haber sido mínimamente probada. Marca o describe las pruebas que has realizado:
How has the changes been tested? (english)
Any modification must have been tested minimally. Mark or describe the tests you have performed:
Ayuda
Aquí tienes algunos enlaces de ayuda:
Help (english)
Here are some help links: