ci: Ensure panic without debug assertions#898
Draft
Sword-Smith wants to merge 1 commit intomasterfrom
Draft
Conversation
A number of tests must panic, also when debug assertions are not activated. This should act as a tripwire test against the bad logic I reference here: #816 (comment)
Member
Author
|
This new run of tests takes up to 30 minutes, at least without caching. That's up to 50 % of the total time CI workflow time. Maybe it's too high a price to pay? If we instead run these tests through separated crates, by placing them in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of tests must panic, also when debug assertions are not activated. This should act as a tripwire test against the bad logic I reference here:
#816 (comment)
Please don't bother considering this before we have a result from CI.