Integrating poisson and log-normal simulations #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owing a full covariance with a simple basic approximation
…, as well as a sims_general module to try something enw
… map (convergence map)
…lter to create a mask for point sources
…tions in poisson map, simple match filter to create a mask for point sources
Member
Sebastian-Belkner
left a comment
Sebastian-Belkner
left a comment
There was a problem hiding this comment.
Looks good to me.
As this is a new feature, can we have a minimal working example of how to use the new sims?
A couple of lines showing how you generate lognormal sims would help a lot.
Member
There was a problem hiding this comment.
Why is this called "extra"? Is this a reference to extragalactic?
Contributor
Author
There was a problem hiding this comment.
Probably will take out this, but yes, it was for that purpose.
Contributor
Author
There was a problem hiding this comment.
Ok! Thanks for looking into this. Will put an example.
Member
|
@Saladino93 what's the status here? looks like we still have merge conflicts for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have written a first version for the log-normal and poisson simulations. These were useful for foregrounds and non-Gaussianity test I have made for the projects.
I imagine they would be useful in general.
Also, implemented a first version to make it easy to combine sims at a more higher level (e.g. if I have a class with CMB+noise, and a class with foregrounds only, "summing" the classes allows me to get a tmap with CMB+noise+foregrounds).