feat: Export TerminalCanvas, BorderStyle, and AsciiLayoutEngine#91
Open
FXschwartz wants to merge 1 commit into
Open
feat: Export TerminalCanvas, BorderStyle, and AsciiLayoutEngine#91FXschwartz wants to merge 1 commit into
FXschwartz wants to merge 1 commit into
Conversation
8 tasks
There was a problem hiding this comment.
Pull request overview
This PR formalizes nocterm’s public API surface by exporting three symbols that were already effectively public via type leakage, allowing downstream users to avoid implementation_imports of lib/src/....
Changes:
- Re-export
AsciiLayoutEnginealongside the existingAsciiLayoutConfig/AsciiLayoutResultexports. - Export
TerminalCanvasandBorderStylefrom the mainpackage:nocterm/nocterm.dartentrypoint. - Keep exports narrowly scoped via
showto avoid unintentionally widening the public surface.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/src/components/ascii_text.dart | Expands the convenience re-export to include AsciiLayoutEngine. |
| lib/nocterm.dart | Exposes TerminalCanvas and BorderStyle as first-class public API exports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three already public by association symbols to nocterm's public API:
TerminalCanvasandBorderStyle(lib/nocterm.dart)AsciiLayoutEngine(lib/src/components/ascii_text.dart, next to the existingAsciiLayoutConfig/AsciiLayoutResultexports)These types are already part of nocterm's public surface but weren't exported:
Downstream packages that use these have to via
import 'package:nocterm/src/...'with// ignore: implementation_imports.This is mainly to get Copilot to stop complaining about this on our PR's 😅