Fix FileBase upload area persistence and no-results menu handling#634
Open
Juergen-Coding wants to merge 1 commit intoNuSkooler:masterfrom
Open
Fix FileBase upload area persistence and no-results menu handling#634Juergen-Coding wants to merge 1 commit intoNuSkooler:masterfrom
Juergen-Coding wants to merge 1 commit intoNuSkooler:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two FileBase-related issues:
Problem 1: wrong upload target area
When uploading a file through the FileBase UI, the selected target area was not reliably preserved after returning from the protocol transfer module.
As a result, the upload handler could fall back to the first available file area instead of using the selected one.
In local testing, uploads always fell back to the first configured area (
bbs) even when another area such astextehad been selected.Root cause
The upload module lost the selected area context during the round-trip through protocol selection and file receive handling.
After returning from the transfer module, the upload workflow resumed with transferred files present, but without a valid selected area in memory, which triggered a fallback to the first available area.
Fix
core/upload.jsNoHistorybehavior from the upload moduleThis prevents the helper state file from being processed as an uploaded file.
Problem 2: FileBase no-results handling
The FileBase "no entries found meeting your filter criteria" screen used outdated menu handling and could fail to return cleanly.
Fix
menu configuration
Updated the
fileBaseListEntriesNoResultsmenu entry so it no longer uses the problematic old no-history behavior.Result
After the patch:
Verified locally
Example successful test:
texte/home/enigma/enigma-bbs/file_base/texteObserved log flow:
areaTag: 'texte'/home/enigma/enigma-bbs/file_base/texteFiles changed
core/upload.jsfileBaseListEntriesNoResultsNotes
This was tested locally and resolved both issues in practice.
It may still be worth reviewing whether upload area persistence should be handled more natively inside the upload/module flow, rather than requiring external persistence between menu transitions.