v3.2: First pass at a style solution for cookies
#4822
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handrews
added
the
param serialization
We need to replace the not-very-functional style: form when it comes to cookies.
3 tasks
|
This is probably the best we can do at the moment, so +1 from me. Can we have an example for |
Yup. Given two generally-positive reactions it's worth rounding this PR out as you suggest and taking it out of draft. Will do shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
style: form(the default and only allowed value for cookies) has never really made sense, and a casual survey of implementations shows that it has been interpreted in ways that are rather surprising (e.g. stuffing an entire query string, percent-encoded including the delimiters, as the cookie value), where it is supported at all.Rather than try to redefine how
style: formbehaves in the context ofin: cookie, we can just definestyle: cookiethat does what makes sense. Regrettably, compatibility rules prevent changing the default.This is a draft because if this is accepted, there's a bit more tweaking to do, particularly with Appendix D. Also, I'd probably add an example.