Skip to content

[16.0][OU-FIX] website: Do BS conversion with sanitization override + Add website editors to sanitization override group#5216

Merged
pedrobaeza merged 2 commits intoOCA:16.0from
Tecnativa:16.0-ou_fix-website-sanitize
Jul 26, 2025
Merged

[16.0][OU-FIX] website: Do BS conversion with sanitization override + Add website editors to sanitization override group#5216
pedrobaeza merged 2 commits intoOCA:16.0from
Tecnativa:16.0-ou_fix-website-sanitize

Conversation

@pedrobaeza
Copy link
Copy Markdown
Member

  • Certain fields had sanitize=False or other sanitization disablings (like sanitize_attributes=False or sanitize_form=False), so when converting to BS 5, we should allow to save the result without re-sanitizing such content. For that, if the user is not on the sanitize overridable group, we add it, removing it after conversion.
  • Website editors that come from v15, where there was no sanitization, would expect the same on the new version, or worst: they introduced some content like iframe in 15, and re-editing that content in 16 leads to lose it when saving it. Thus, let's add all of them to the override sanitization group for keeping the same behavior.

@Tecnativa

Certain fields had sanitize=False or other sanitization disablings (like
sanitize_attributes=False or sanitize_form=False), so when converting to
BS 5, we should allow to save the result without re-sanitizing such
content. For that, if the user is not on the sanitize overridable group,
we add it, removing it after conversion.
Website editors that come from v15, where there was no sanitization,
would expect the same on the new version, or worst: they introduced some
content like iframe in 15, and re-editing that content in 16 leads to
lose it when saving it. Thus, let's add all of them to the override
sanitization group for keeping the same behavior.
@pedrobaeza pedrobaeza added this to the 16.0 milestone Jul 26, 2025
@pedrobaeza pedrobaeza merged commit e441ce2 into OCA:16.0 Jul 26, 2025
2 checks passed
@pedrobaeza pedrobaeza deleted the 16.0-ou_fix-website-sanitize branch July 26, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant