-
-
Notifications
You must be signed in to change notification settings - Fork 868
[19.0][MIG] account_move_line_sale_info #2201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
[19.0][MIG] account_move_line_sale_info #2201
Conversation
…d to use the product.
Currently translated at 100.0% (8 of 8 strings) Translation: account-financial-tools-15.0/account-financial-tools-15.0-account_move_line_sale_info Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-15-0/account-financial-tools-15-0-account_move_line_sale_info/es_AR/
…n to credit notes
Currently translated at 100.0% (8 of 8 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_move_line_sale_info Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_move_line_sale_info/es/
Currently translated at 100.0% (8 of 8 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_move_line_sale_info Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_move_line_sale_info/it/
Currently translated at 100.0% (8 of 8 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_move_line_sale_info Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_move_line_sale_info/it/
[MIG] account_move_line_sale_info: Migration to 18.0
Currently translated at 100.0% (8 of 8 strings) Translation: account-financial-tools-18.0/account-financial-tools-18.0-account_move_line_sale_info Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-18-0/account-financial-tools-18-0-account_move_line_sale_info/tr/
AaronHForgeFlow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional + code 👍 just some minor comments
account_move_line_sale_info/hooks.py
Outdated
| def post_init_hook(env): | ||
| """INIT sale references in account move line""" | ||
| # FOR stock moves | ||
| env.cr.execute( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This query is not necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, Thanks
account_move_line_sale_info/hooks.py
Outdated
| # NOW we can fill the lines without invoice_id (Odoo put it very | ||
| # complicated) | ||
|
|
||
| env.cr.execute( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neither this one (it was for stock move entries also)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, Thanks
account_move_line_sale_info/hooks.py
Outdated
| """ | ||
| ) | ||
|
|
||
| env.cr.execute( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neither this one I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, Thanks
fa9db05 to
dfc79ce
Compare
AaronHForgeFlow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional + code LGTM
Standard Migration
Remove dependency of account_move_line_stock_info as Odoo 19 has refactored stock valuation
@ForgeFlow