Skip to content

[19.0][MIG] account_asset_management: Migration to 19#2206

Open
acysos wants to merge 207 commits intoOCA:19.0from
acysos:19.0-mig-account_asset_management
Open

[19.0][MIG] account_asset_management: Migration to 19#2206
acysos wants to merge 207 commits intoOCA:19.0from
acysos:19.0-mig-account_asset_management

Conversation

@acysos
Copy link
Member

@acysos acysos commented Jan 25, 2026

Migration to 19.0

lepistone and others added 30 commits January 25, 2026 20:25
add asset management modules

asset mgt update

redo

synch asset mgt with recent V7 changes
[UPD] add places arg in assertAlmostEqual tests

[UPD] flake clean
…an't be modified if a move is linked with a depriciation line

[IMP][account_asset_management] Define FIELDS_AFFETCS_ASSET_MOVE as a set directly
* Fix compute methods dependencies and small optimizations
* Rename demo file to test and move it into the right folder
This is now supported natively by Odoo 11.
* account_asset: Do not loop on all the lines to search for one linked asset

Before this change, the use of `mapped` on self did loop on all the move
lines that are included in self to get the assets, what could be very
costly for a simple write on a lot of move lines. As the goal is to raise
an error only if at least one move is linked to an asset, we break the
loop if the condition is fulfilled.

* performance improvement

* [RMV] - Remove useless dependency

In 12.0 account_fiscal_year is a standard feature no need to depend on oca
module account_fiscal_year
Currently translated at 40.1% (79 of 197 strings)

Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_asset_management
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_asset_management/pt_BR/
Currently translated at 100.0% (195 of 195 strings)

Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_asset_management
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_asset_management/fr/
Currently translated at 91.8% (179 of 195 strings)

Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_asset_management
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_asset_management/es/
…ount_per_fiscal_year

This way, other method_time mechanism like localization ones is able to overwrite it.

You also got an error of variable `number` not set due to previous code. Although no
alternate implementation for a new method_time, now you don't have any error,
fallbacking to standard proportional repartition.
…ent from extra method_time values

If not, added methods won't hide these fields.
oca-ci and others added 13 commits January 25, 2026 20:25
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-tools-18.0/account-financial-tools-18.0-account_asset_management
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-18-0/account-financial-tools-18-0-account_asset_management/
Currently translated at 100.0% (255 of 255 strings)

Translation: account-financial-tools-18.0/account-financial-tools-18.0-account_asset_management
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-18-0/account-financial-tools-18-0-account_asset_management/tr/
Currently translated at 100.0% (255 of 255 strings)

Translation: account-financial-tools-18.0/account-financial-tools-18.0-account_asset_management
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-18-0/account-financial-tools-18-0-account_asset_management/it/
Currently translated at 100.0% (255 of 255 strings)

Translation: account-financial-tools-18.0/account-financial-tools-18.0-account_asset_management
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-18-0/account-financial-tools-18-0-account_asset_management/sv/
Currently translated at 100.0% (255 of 255 strings)

Translation: account-financial-tools-18.0/account-financial-tools-18.0-account_asset_management
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-18-0/account-financial-tools-18-0-account_asset_management/sv/
Currently translated at 100.0% (255 of 255 strings)

Translation: account-financial-tools-18.0/account-financial-tools-18.0-account_asset_management
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-18-0/account-financial-tools-18-0-account_asset_management/sv/
Currently translated at 100.0% (255 of 255 strings)

Translation: account-financial-tools-18.0/account-financial-tools-18.0-account_asset_management
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-18-0/account-financial-tools-18-0-account_asset_management/sv/
Currently translated at 100.0% (255 of 255 strings)

Translation: account-financial-tools-18.0/account-financial-tools-18.0-account_asset_management
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-18-0/account-financial-tools-18-0-account_asset_management/ca/
@acysos acysos mentioned this pull request Jan 25, 2026
34 tasks
@acysos acysos force-pushed the 19.0-mig-account_asset_management branch 3 times, most recently from f699c80 to 9d1dc49 Compare January 25, 2026 22:54
@acysos
Copy link
Member Author

acysos commented Jan 26, 2026

Hello,

codevoc/project give red, but the report don't show nothing, only the percentages.
Can some one help us?

Thank you

@pedrobaeza pedrobaeza changed the title 19.0 mig account asset management [19.0][MIG] account_asset_management: Migration to 19 Jan 27, 2026
@pedrobaeza
Copy link
Member

/ocabot migration account_asset_management

You can see the coverage in https://app.codecov.io/gh/OCA/account-financial-tools/pull/2206?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=checks&utm_campaign=pr+comments&utm_term=OCA, but that check is not enforced and can be red.

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Jan 27, 2026
@acysos
Copy link
Member Author

acysos commented Jan 27, 2026

You can see the coverage in https://app.codecov.io/gh/OCA/account-financial-tools/pull/2206?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=checks&utm_campaign=pr+comments&utm_term=OCA, but that check is not enforced and can be red.

Hi, I saw the report. In other instances, it highlights the uncovered lines, but this time it isn't displaying anything specific. It only reports a coverage drop with no further details, and everything shows as 0.

@pedrobaeza
Copy link
Member

Uhm, I see, can you do git commit --all --amend and then git push -f to trigger another build?

[MIG] account_asset_management: Migration to 19.0

[MIG] account_asset_management: Migration to 19.0

[MIG] account_asset_management: Migration to 19.0

[MIG] account_asset_management: Migration to 19.0

[MIG] account_asset_management: Migration to 19.0

[MIG] account_asset_management: Migration to 19.0

[MIG] account_asset_management: Migration to 19.0

[MIG] account_asset_management: Migration to 19.0

[MIG] account_asset_management: Migration to 19.0

[MIG] account_asset_management: Migration to 19.0
@acysos acysos force-pushed the 19.0-mig-account_asset_management branch from 9d1dc49 to 78bea05 Compare January 27, 2026 15:00
@acysos
Copy link
Member Author

acysos commented Jan 27, 2026

It's the same issue, the report is blank.

@pedrobaeza
Copy link
Member

Definitively it should be a failure in Codecov or the CI triggers. Not sure if @sbidoul knows the internal of this.

@acysos
Copy link
Member Author

acysos commented Jan 27, 2026

I'm checking this PR OCA/account-financial-reporting#1413 and Codecov has the same issue. It seems to be a general problem.

@Honeyxilia
Copy link
Contributor

Honeyxilia commented Feb 4, 2026

Hello - we migrated from the v12.0 to v16.0 a BI report on Assets, which adds a view to see the revenue related to several assets from within Odoo c:

The BI report was only added after the v13.0 migration of the account_asset_management module, which was then migrated subsequently without it.
As such, we thought it was a shame it wasn't available in more recent versions, and we ported it to 16.0

Would you be interested in porting it to v19 within this PR ?
#2212

@florian-dacosta
Copy link
Contributor

Hello @acysos Could you take a look on this one please ? #2160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.