[MIG][17.0] forward missing commits from 16.0 to 17.0 #2224
+229
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating moves or invoices, it can be useful to easily access 'vals' to create move_lines.
1. We allow to change the currency on the loan if the user needs it
2. If the currency on the loan (or on the journal) is different from the one on the company, we do the conversion for credit/debit + add amount in currency on the move line
Contributor
|
Hi @etobella, |
petrus-v
force-pushed
the
17.0-forward-port-missing-commits-16-to-17
branch
from
8170cb6 to
b496587
Compare
AnizR
reviewed
Feb 12, 2026
Contributor
AnizR
left a comment
AnizR
left a comment
There was a problem hiding this comment.
Code looks good to me, I'd like to discuss my comment on oca-port's blacklist before approving.
| @@ -0,0 +1,11 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
Is this file really necessary?
I don't think oca-port's blacklist should be visible in the PR.
Contributor
Author
There was a problem hiding this comment.
I can see this file is followed by git in other repo (ie stock_dynamic_routing module
As far I've understood this is the knowledge to tell to oca-port to ignore those PRs while running it the next time, other wise oca port would suggest again and again those PRs.
@sebalix thanks for such great tool ❤️ , could you confirm:
- we want share and versioned those files
- my understanding is correct
- the kind of message expected here, is it what the PR does or why we decide to ignore it (I admit my first message can be suspicious 😅 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port PRs from 16.0 to 17.0: