-
-
Notifications
You must be signed in to change notification settings - Fork 198
[18.0][MIG] base_maintenance_group: Migration to 18.0 #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] base_maintenance_group: Migration to 18.0 #446
Conversation
e830db3 to
5a08128
Compare
Currently translated at 100.0% (3 of 3 strings) Translation: maintenance-12.0/maintenance-12.0-base_maintenance_group Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-base_maintenance_group/pt_BR/
…where user is join in
Currently translated at 100.0% (3 of 3 strings) Translation: maintenance-12.0/maintenance-12.0-base_maintenance_group Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-base_maintenance_group/it/
The 'users' parameter is res.users and 'base.group_system' is res.groups. Two distinct models!!! It should be base.user_admin instead.
Currently translated at 100.0% (3 of 3 strings) Translation: maintenance-16.0/maintenance-16.0-base_maintenance_group Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-base_maintenance_group/es/
5a08128 to
e4068fc
Compare
ypapouin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BhaveshHeliconia , please rebase to update runboat status.
Also take advantage of this migration to rename menuitems.xml and move it to a views folder: base_maintenance_group/views/maintenance_views.xml
e4068fc to
eed7e51
Compare
|
@ypapouin : Please review. Thanks |
|
Hey @OCA/maintenance-maintainers Could you merge this ? |
|
@etobella : Please take a look at this module as well. |
etobella
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot migration base_maintenance_group
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 67325fe. Thanks a lot for contributing to OCA. ❤️ |
No description provided.