[18.0][MIG] maintenance_product: Migration to 18.0 #451
[18.0][MIG] maintenance_product: Migration to 18.0 #451OCA-git-bot merged 13 commits intoOCA:18.0from
Conversation
BhaveshHeliconia
force-pushed
the
18.0-mig-maintenance_product
branch
from
3882271 to
316ffed
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
ping @OCA/maintenance-maintainers |
|
Please rebase |
Currently translated at 100.0% (11 of 11 strings) Translation: maintenance-14.0/maintenance-14.0-maintenance_product Translate-URL: https://translation.odoo-community.org/projects/maintenance-14-0/maintenance-14-0-maintenance_product/it/
Currently translated at 100.0% (11 of 11 strings) Translation: maintenance-15.0/maintenance-15.0-maintenance_product Translate-URL: https://translation.odoo-community.org/projects/maintenance-15-0/maintenance-15-0-maintenance_product/es/
Currently translated at 100.0% (8 of 8 strings) Translation: maintenance-16.0/maintenance-16.0-maintenance_product Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_product/it/
Currently translated at 100.0% (8 of 8 strings) Translation: maintenance-16.0/maintenance-16.0-maintenance_product Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_product/es/
BhaveshHeliconia
force-pushed
the
18.0-mig-maintenance_product
branch
from
316ffed to
5647f09
Compare
|
@etobella : It's Done. Thanks |
| comodel_name="product.product", | ||
| string="Product", | ||
| tracking=True, | ||
| domain="[('categ_id','=',product_category_id),('maintenance_ok','=',True)]", |
There was a problem hiding this comment.
categ_id should be child_of of product_category_id
BhaveshHeliconia
force-pushed
the
18.0-mig-maintenance_product
branch
from
5647f09 to
a2ee2aa
Compare
|
@etobella : Please review. Thanks |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 94661cc. Thanks a lot for contributing to OCA. ❤️ |
| domain=[ | ||
| ("categ_id", "child_of", "product_category_id"), | ||
| ("maintenance_ok", "=", True), | ||
| ], |
There was a problem hiding this comment.
@BhaveshHeliconia
As the domain is structured now, it will always return the string 'product_category_id' instead of the actual ID.
You probably want something like:
"[('categ_id', 'child_of', product_category_id), ('maintenance_ok', '=', True)]"
so that product_category_id is evaluated properly.
9 participants
No description provided.