-
-
Notifications
You must be signed in to change notification settings - Fork 198
[18.0][MIG] maintenance_equipment_hierarchy: Migration to 18.0 #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] maintenance_equipment_hierarchy: Migration to 18.0 #454
Conversation
Currently translated at 100.0% (11 of 11 strings) Translation: maintenance-11.0/maintenance-11.0-maintenance_equipment_hierarchy Translate-URL: https://translation.odoo-community.org/projects/maintenance-11-0/maintenance-11-0-maintenance_equipment_hierarchy/es/
[UPD] Update maintenance_equipment_hierarchy.pot
Currently translated at 33.3% (4 of 12 strings) Translation: maintenance-13.0/maintenance-13.0-maintenance_equipment_hierarchy Translate-URL: https://translation.odoo-community.org/projects/maintenance-13-0/maintenance-13-0-maintenance_equipment_hierarchy/fr_FR/
Currently translated at 100.0% (12 of 12 strings) Translation: maintenance-13.0/maintenance-13.0-maintenance_equipment_hierarchy Translate-URL: https://translation.odoo-community.org/projects/maintenance-13-0/maintenance-13-0-maintenance_equipment_hierarchy/it/
…ake field translatable
Currently translated at 100.0% (12 of 12 strings) Translation: maintenance-16.0/maintenance-16.0-maintenance_equipment_hierarchy Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_equipment_hierarchy/it/
…ads wrongly to parent equipment
…nt_path as proposed by warning logs
Currently translated at 100.0% (13 of 13 strings) Translation: maintenance-16.0/maintenance-16.0-maintenance_equipment_hierarchy Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_equipment_hierarchy/it/
Currently translated at 100.0% (13 of 13 strings) Translation: maintenance-16.0/maintenance-16.0-maintenance_equipment_hierarchy Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_equipment_hierarchy/it/
Currently translated at 100.0% (13 of 13 strings) Translation: maintenance-16.0/maintenance-16.0-maintenance_equipment_hierarchy Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_equipment_hierarchy/it/
Currently translated at 100.0% (13 of 13 strings) Translation: maintenance-16.0/maintenance-16.0-maintenance_equipment_hierarchy Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_equipment_hierarchy/es/
|
@dalonsod : Please review again. Thanks. |
|
Reviewing commit history I've notice that doesn't include stuff from v17.0 version, could you check? I've found at least two commits of my own authorship (9494d70 and 9a921a8) that are not included, and it shouldn't be merged in another one without respecting authorship. In other words, this migration should start from the complete commit history of v17 addon version. |
@dalonsod You're absolutely right — it appears I performed the migration from version 16.0. I’ll make the necessary corrections right away. I truly value and respect every contribution made by the community; this was simply a case of incorrect migration steps on my part. Thank you for your understanding and for taking the time to review it. |
|
Hello @BhaveshHeliconia will resume this? |
|
@BhaveshHeliconia There was a fix introduced in version 17.0 via PR #495. Could you please cherry-pick commit 1379db7? Also, kindly update the commit history as per @dalonsod’s suggestion. |
|
@BhaveshHeliconia A kind reminder here, are you going to attend remaining comments? |
dc1e040 to
96bd1ea
Compare
|
@dalonsod @LoisRForgeFlow : Please review and let me know if everything is proper now or if I’m still missing something. |
|
@dalonsod @DantePereyra Maybe you can confirm better if your requests have been attended. |
Fix added by that PR is already available here, but included into |
…childs Before this fix, when we're trying to create a child equipment from child equipments list view for a certain equipment, an error was raised. This fixes it.
96bd1ea to
13c9dc8
Compare
|
@dalonsod : Please review and let me know if everything is proper now or if I’m still missing something. Thank you! |
dalonsod
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks for later adjustments
|
This PR has the |
etobella
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge nobump
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 502cc19. Thanks a lot for contributing to OCA. ❤️ |
No description provided.