Skip to content

Conversation

@BhaveshHeliconia
Copy link
Contributor

No description provided.

@BhaveshHeliconia BhaveshHeliconia mentioned this pull request Jan 27, 2025
16 tasks
JordiBForgeFlow and others added 29 commits April 1, 2025 12:06
Currently translated at 100.0% (11 of 11 strings)

Translation: maintenance-11.0/maintenance-11.0-maintenance_equipment_hierarchy
Translate-URL: https://translation.odoo-community.org/projects/maintenance-11-0/maintenance-11-0-maintenance_equipment_hierarchy/es/
[UPD] Update maintenance_equipment_hierarchy.pot
Currently translated at 33.3% (4 of 12 strings)

Translation: maintenance-13.0/maintenance-13.0-maintenance_equipment_hierarchy
Translate-URL: https://translation.odoo-community.org/projects/maintenance-13-0/maintenance-13-0-maintenance_equipment_hierarchy/fr_FR/
Currently translated at 100.0% (12 of 12 strings)

Translation: maintenance-13.0/maintenance-13.0-maintenance_equipment_hierarchy
Translate-URL: https://translation.odoo-community.org/projects/maintenance-13-0/maintenance-13-0-maintenance_equipment_hierarchy/it/
Currently translated at 100.0% (12 of 12 strings)

Translation: maintenance-16.0/maintenance-16.0-maintenance_equipment_hierarchy
Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_equipment_hierarchy/it/
Currently translated at 100.0% (13 of 13 strings)

Translation: maintenance-16.0/maintenance-16.0-maintenance_equipment_hierarchy
Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_equipment_hierarchy/it/
Currently translated at 100.0% (13 of 13 strings)

Translation: maintenance-16.0/maintenance-16.0-maintenance_equipment_hierarchy
Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_equipment_hierarchy/it/
Currently translated at 100.0% (13 of 13 strings)

Translation: maintenance-16.0/maintenance-16.0-maintenance_equipment_hierarchy
Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_equipment_hierarchy/it/
Currently translated at 100.0% (13 of 13 strings)

Translation: maintenance-16.0/maintenance-16.0-maintenance_equipment_hierarchy
Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_equipment_hierarchy/es/
@BhaveshHeliconia
Copy link
Contributor Author

@dalonsod : Please review again. Thanks.

@dalonsod
Copy link
Contributor

dalonsod commented Jun 3, 2025

Reviewing commit history I've notice that doesn't include stuff from v17.0 version, could you check? I've found at least two commits of my own authorship (9494d70 and 9a921a8) that are not included, and it shouldn't be merged in another one without respecting authorship.

In other words, this migration should start from the complete commit history of v17 addon version.

@BhaveshHeliconia
Copy link
Contributor Author

Reviewing commit history I've notice that doesn't include stuff from v17.0 version, could you check? I've found at least two commits of my own authorship (9494d70 and 9a921a8) that are not included, and it shouldn't be merged in another one without respecting authorship.

In other words, this migration should start from the complete commit history of v17 addon version.

@dalonsod You're absolutely right — it appears I performed the migration from version 16.0. I’ll make the necessary corrections right away. I truly value and respect every contribution made by the community; this was simply a case of incorrect migration steps on my part. Thank you for your understanding and for taking the time to review it.

@dalonsod
Copy link
Contributor

Hello @BhaveshHeliconia will resume this?

@DantePereyra
Copy link

@BhaveshHeliconia There was a fix introduced in version 17.0 via PR #495. Could you please cherry-pick commit 1379db7? Also, kindly update the commit history as per @dalonsod’s suggestion.

@LoisRForgeFlow
Copy link
Contributor

@BhaveshHeliconia A kind reminder here, are you going to attend remaining comments?

@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-maintenance_equipment_hierarchy branch 2 times, most recently from dc1e040 to 96bd1ea Compare September 3, 2025 04:27
@BhaveshHeliconia
Copy link
Contributor Author

BhaveshHeliconia commented Sep 3, 2025

@dalonsod @LoisRForgeFlow : Please review and let me know if everything is proper now or if I’m still missing something.

@LoisRForgeFlow
Copy link
Contributor

@dalonsod @DantePereyra Maybe you can confirm better if your requests have been attended.

@dalonsod
Copy link
Contributor

dalonsod commented Sep 4, 2025

There was a fix introduced in version 17.0 via PR #495. Could you please cherry-pick commit 1379db7?

Fix added by that PR is already available here, but included into 18.0 migration commit, not cherry-picking it before, as proposed, could you check @BhaveshHeliconia ?

dalonsod and others added 2 commits September 4, 2025 16:23
…childs

Before this fix, when we're trying to create a child equipment from
child equipments list view for a certain equipment, an error was raised.
This fixes it.
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-maintenance_equipment_hierarchy branch from 96bd1ea to 13c9dc8 Compare September 4, 2025 10:55
@BhaveshHeliconia
Copy link
Contributor Author

@dalonsod : Please review and let me know if everything is proper now or if I’m still missing something. Thank you!

Copy link
Contributor

@dalonsod dalonsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for later adjustments

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-454-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5cc98db into OCA:18.0 Sep 15, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 502cc19. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.