Skip to content

[18.0][MIG] maintenance_equipment_status: Migration to 18.0 #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OCA-git-bot merged 29 commits into from
Aug 26, 2025
Merged

[18.0][MIG] maintenance_equipment_status: Migration to 18.0 #456

OCA-git-bot merged 29 commits into from
Aug 26, 2025

Conversation

@BhaveshHeliconia
Copy link
Contributor

@BhaveshHeliconia BhaveshHeliconia commented Jan 27, 2025 •
edited
Loading

No description provided.

@BhaveshHeliconia BhaveshHeliconia mentioned this pull request Jan 27, 2025
Open
16 tasks
@github-actions
Copy link

github-actions bot commented Jun 8, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 8, 2025
JordiBForgeFlow and others added 26 commits June 9, 2025 16:05
@JordiBForgeFlow @BhaveshHeliconia
[11.0][ADD] maintenance_equipment_status
80b5af0
@BhaveshHeliconia
Added translation using Weblate (Spanish)
525af3c
@BhaveshHeliconia
Translated using Weblate (Spanish)
8c49a27 
Currently translated at 100.0% (22 of 22 strings)

Translation: maintenance-11.0/maintenance-11.0-maintenance_equipment_status
Translate-URL: https://translation.odoo-community.org/projects/maintenance-11-0/maintenance-11-0-maintenance_equipment_status/es/
@etobella @BhaveshHeliconia
Translated using Weblate (Spanish)
98a17d3 
Currently translated at 100.0% (22 of 22 strings)

Translation: maintenance-11.0/maintenance-11.0-maintenance_equipment_status
Translate-URL: https://translation.odoo-community.org/projects/maintenance-11-0/maintenance-11-0-maintenance_equipment_status/es/
@NuriaXifre @BhaveshHeliconia
[12.0][MIG] maintenance_equipment_status
aa9f9cb
@JoanSForgeFlow @BhaveshHeliconia
[IMP] maintenance_equipment_status: black, isort
2fc1d8e
@JoanSForgeFlow @BhaveshHeliconia
[MIG] maintenance_equipment_status: Migration to 13.0
7402215
@dalonsod @BhaveshHeliconia
[FIX] maintenance_equipment_status: status not clickable on equipment…
9411509 
… form
@dalonsod @BhaveshHeliconia
[IMP] maintenance_equipment_status: black, isort, prettier
15eea77
@dalonsod @BhaveshHeliconia
[MIG] maintenance_equipment_status: Migration to 14.0
05b3c78
@mymage @BhaveshHeliconia
Added translation using Weblate (Italian)
98d41b3
@mymage @BhaveshHeliconia
Translated using Weblate (Italian)
30007d1 
Currently translated at 100.0% (21 of 21 strings)

Translation: maintenance-14.0/maintenance-14.0-maintenance_equipment_status
Translate-URL: https://translation.odoo-community.org/projects/maintenance-14-0/maintenance-14-0-maintenance_equipment_status/it/
@mariadforgeflow @BhaveshHeliconia
[IMP] maintenance_equipment_status: black, isort, prettier
2a420b0
@mariadforgeflow @BhaveshHeliconia
[MIG] maintenance_equipment_status: Migration to 15.0
581f469
@BhaveshHeliconia
[UPD] Update maintenance_equipment_status.pot
e6a0370
@OCA-git-bot @BhaveshHeliconia
[UPD] README.rst
6302b3c
@francesco-ooops @BhaveshHeliconia
Translated using Weblate (Italian)
750ead6 
Currently translated at 100.0% (21 of 21 strings)

Translation: maintenance-15.0/maintenance-15.0-maintenance_equipment_status
Translate-URL: https://translation.odoo-community.org/projects/maintenance-15-0/maintenance-15-0-maintenance_equipment_status/it/
@HekkiMelody @BhaveshHeliconia
[MIG] maintenance_equipment_status: Migration to 16.0
b711b8b
@BhaveshHeliconia
[UPD] Update maintenance_equipment_status.pot
bd59ce2
@OCA-git-bot @BhaveshHeliconia
[UPD] README.rst
046e505
@weblate @BhaveshHeliconia
Update translation files
60e5c2d 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: maintenance-16.0/maintenance-16.0-maintenance_equipment_status
Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_equipment_status/
@mymage @BhaveshHeliconia
Translated using Weblate (Italian)
44be611 
Currently translated at 100.0% (22 of 22 strings)

Translation: maintenance-16.0/maintenance-16.0-maintenance_equipment_status
Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_equipment_status/it/
@francesco-ooops @BhaveshHeliconia
Translated using Weblate (Italian)
349a8b9 
Currently translated at 100.0% (22 of 22 strings)

Translation: maintenance-16.0/maintenance-16.0-maintenance_equipment_status
Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_equipment_status/it/
@Ivorra78 @BhaveshHeliconia
Translated using Weblate (Spanish)
b796e68 
Currently translated at 95.4% (21 of 22 strings)

Translation: maintenance-16.0/maintenance-16.0-maintenance_equipment_status
Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_equipment_status/es/
@Ivorra78 @BhaveshHeliconia
Translated using Weblate (Spanish)
3a0823b 
Currently translated at 100.0% (22 of 22 strings)

Translation: maintenance-16.0/maintenance-16.0-maintenance_equipment_status
Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_equipment_status/es/
@OCA-git-bot @BhaveshHeliconia
[UPD] README.rst
94376e8
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-maintenance_equipment_status branch from 6796dd1 to c3a153c Compare June 9, 2025 10:36
marcelsavegnago
marcelsavegnago approved these changes Jun 25, 2025
View reviewed changes
Copy link
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dalonsod
dalonsod suggested changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@dalonsod dalonsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This migration started from v16, while v17 version was already available.

Then, commit history is incomplete, some commits and their authorships are missing. Even new contributors for v17 are lost. Commit history should be fixed IMO.

LoisRForgeFlow
LoisRForgeFlow suggested changes Jul 15, 2025
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This migration started from v16, while v17 version was already available.

Then, commit history is incomplete, some commits and their authorships are missing. Even new contributors for v17 are lost. Commit history should be fixed IMO.

@BhaveshHeliconia are you going to fix this?

@BhaveshHeliconia
Copy link
Contributor Author

BhaveshHeliconia commented Aug 7, 2025

@dalonsod @LoisRForgeFlow : Understood—thanks for the clarification. To fix the commit history, how can I retrieve the missing v17 history and insert it before my last two commits? I'd appreciate your guidance.

@LoisRForgeFlow
Copy link
Contributor

LoisRForgeFlow commented Aug 7, 2025

@BhaveshHeliconia Sometimes the easiest is to just "replay" migration: reset hard to 18.0 and rerun migration commands, then apply the same changes you did for migrating.

@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-maintenance_equipment_status branch from 464f298 to 4001a03 Compare August 8, 2025 03:26
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-maintenance_equipment_status branch from 4001a03 to 55c1c49 Compare August 8, 2025 03:28
@BhaveshHeliconia
Copy link
Contributor Author

BhaveshHeliconia commented Aug 8, 2025

@LoisRForgeFlow : Please check if everything is proper now.

LoisRForgeFlow
LoisRForgeFlow approved these changes Aug 18, 2025
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, It looks good to me now 👍

Thanks for adding tests during migration

@LoisRForgeFlow
Copy link
Contributor

LoisRForgeFlow commented Aug 18, 2025

@dalonsod could you update your review?

dalonsod
dalonsod approved these changes Aug 18, 2025
View reviewed changes
Copy link
Contributor

@dalonsod dalonsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I miss for this addon some search view stuff at equipments action (search by status, grouping by status), but is non-blocking anyway.

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Aug 18, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@BhaveshHeliconia
Copy link
Contributor Author

BhaveshHeliconia commented Aug 26, 2025

Hey @OCA/maintenance-maintainers Could you merge this?

etobella
etobella approved these changes Aug 26, 2025
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@etobella
Copy link
Member

etobella commented Aug 26, 2025

/ocabot migration maintenance_equipment_status

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Aug 26, 2025
@etobella
Copy link
Member

etobella commented Aug 26, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Aug 26, 2025

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-456-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4ba502e into OCA:18.0 Aug 26, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Aug 26, 2025

Congratulations, your PR was merged at 80215f4. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etobella etobella etobella approved these changes

+5 more reviewers

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@dalonsod dalonsod dalonsod approved these changes

@ypapouin ypapouin ypapouin approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

@ThiagoMForgeFlow ThiagoMForgeFlow ThiagoMForgeFlow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.