[19.0][MIG] partner_industry_secondary: Migration to 19.0#2283
[19.0][MIG] partner_industry_secondary: Migration to 19.0#2283OCA-git-bot merged 49 commits intoOCA:19.0from
Conversation
Currently translated at 83.3% (15 of 18 strings) Translation: partner-contact-12.0/partner-contact-12.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_industry_secondary/hr/
Currently translated at 88.9% (16 of 18 strings) Translation: partner-contact-12.0/partner-contact-12.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_industry_secondary/es/
…when create a company with 2 contacts
Currently translated at 100.0% (17 of 17 strings) Translation: partner-contact-15.0/partner-contact-15.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-15-0/partner-contact-15-0-partner_industry_secondary/ca/
Currently translated at 100.0% (17 of 17 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_industry_secondary/fr/
Currently translated at 100.0% (17 of 17 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_industry_secondary/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-16.0/partner-contact-16.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_industry_secondary/
Currently translated at 100.0% (17 of 17 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_industry_secondary/es/
Currently translated at 100.0% (17 of 17 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_industry_secondary/it/
…ield As asked by Odoo in a warning in _check_parent_path method https://github.com/odoo/odoo/blob/16.0/odoo/models.py#L2615
[IMP] Fix pre-commit and unit tests [IMP] partner_industry_secondary: black, isort, prettier [IMP] partner_industry_secondary: Update unit tests [IMP] partner_industry_secondary: black, isort, prettier
Currently translated at 100.0% (17 of 17 strings) Translation: partner-contact-17.0/partner-contact-17.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-17-0/partner-contact-17-0-partner_industry_secondary/sv/
Currently translated at 100.0% (17 of 17 strings) Translation: partner-contact-18.0/partner-contact-18.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-18-0/partner-contact-18-0-partner_industry_secondary/it/
- Replaced assertRaises with assertRaisesRegex to validate specific error messages. - Added docstrings to each test case for better clarity and documentation.
Currently translated at 100.0% (17 of 17 strings) Translation: partner-contact-18.0/partner-contact-18.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-18-0/partner-contact-18-0-partner_industry_secondary/it/
Currently translated at 23.5% (4 of 17 strings) Translation: partner-contact-18.0/partner-contact-18.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-18-0/partner-contact-18-0-partner_industry_secondary/sl/
Currently translated at 100.0% (17 of 17 strings) Translation: partner-contact-18.0/partner-contact-18.0-partner_industry_secondary Translate-URL: https://translation.odoo-community.org/projects/partner-contact-18-0/partner-contact-18-0-partner_industry_secondary/sl/
luisDIXMIT
left a comment
There was a problem hiding this comment.
Squash migration commits into a single migration commit.
223c978 to
fcd14d1
Compare
luisDIXMIT
left a comment
There was a problem hiding this comment.
Code review and tested on runboat, LGTM! Some minor suggestions.
| <odoo> | ||
| <record id="group_use_partner_industry_for_person" model="res.groups"> | ||
| <field name="name">Use industry for individuals</field> | ||
| <field name="category_id" ref="base.module_category_hidden" /> |
There was a problem hiding this comment.
In version 19, res.groups doesn’t use categories directly but can use res.group.privilege. Can you check that there isn’t a res.group.privilege similar to that category? Maybe it uses the same category.
There was a problem hiding this comment.
@luisDIXMIT In core Odoo, technical groups (previously in category Hidden) were not assigned a privilege. So this seems fine to me. See odoo/odoo@33637d137ed52f5faa
|
LGTM |
|
/ocabot migration partner_industry_secondary |
StefanRijnhart
left a comment
There was a problem hiding this comment.
Thanks!
/ocabot merge nobump
|
This PR looks fantastic, let's merge it! |
|
This PR has the |
|
Congratulations, your PR was merged at 0bd4453. Thanks a lot for contributing to OCA. ❤️ |
No description provided.