Skip to content

[19.0][MIG] partner_industry_secondary: Migration to 19.0#2283

Merged
OCA-git-bot merged 49 commits intoOCA:19.0from
initOS:19.0-mig-partner_industry_secondary
Feb 25, 2026
Merged

[19.0][MIG] partner_industry_secondary: Migration to 19.0#2283
OCA-git-bot merged 49 commits intoOCA:19.0from
initOS:19.0-mig-partner_industry_secondary

Conversation

@muaazsiddiq
Copy link

No description provided.

MiquelRForgeFlow and others added 30 commits February 5, 2026 11:13
Currently translated at 83.3% (15 of 18 strings)

Translation: partner-contact-12.0/partner-contact-12.0-partner_industry_secondary
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_industry_secondary/hr/
Currently translated at 88.9% (16 of 18 strings)

Translation: partner-contact-12.0/partner-contact-12.0-partner_industry_secondary
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_industry_secondary/es/
Currently translated at 100.0% (17 of 17 strings)

Translation: partner-contact-15.0/partner-contact-15.0-partner_industry_secondary
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-15-0/partner-contact-15-0-partner_industry_secondary/ca/
Currently translated at 100.0% (17 of 17 strings)

Translation: partner-contact-16.0/partner-contact-16.0-partner_industry_secondary
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_industry_secondary/fr/
Currently translated at 100.0% (17 of 17 strings)

Translation: partner-contact-16.0/partner-contact-16.0-partner_industry_secondary
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_industry_secondary/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: partner-contact-16.0/partner-contact-16.0-partner_industry_secondary
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_industry_secondary/
Currently translated at 100.0% (17 of 17 strings)

Translation: partner-contact-16.0/partner-contact-16.0-partner_industry_secondary
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_industry_secondary/es/
Currently translated at 100.0% (17 of 17 strings)

Translation: partner-contact-16.0/partner-contact-16.0-partner_industry_secondary
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_industry_secondary/it/
[IMP] Fix pre-commit and unit tests

[IMP] partner_industry_secondary: black, isort, prettier

[IMP] partner_industry_secondary: Update unit tests

[IMP] partner_industry_secondary: black, isort, prettier
Currently translated at 100.0% (17 of 17 strings)

Translation: partner-contact-17.0/partner-contact-17.0-partner_industry_secondary
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-17-0/partner-contact-17-0-partner_industry_secondary/sv/
OCA-git-bot and others added 7 commits February 5, 2026 11:13
Currently translated at 100.0% (17 of 17 strings)

Translation: partner-contact-18.0/partner-contact-18.0-partner_industry_secondary
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-18-0/partner-contact-18-0-partner_industry_secondary/it/
- Replaced assertRaises with assertRaisesRegex to validate specific error messages.
- Added docstrings to each test case for better clarity and documentation.
Currently translated at 100.0% (17 of 17 strings)

Translation: partner-contact-18.0/partner-contact-18.0-partner_industry_secondary
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-18-0/partner-contact-18-0-partner_industry_secondary/it/
Currently translated at 23.5% (4 of 17 strings)

Translation: partner-contact-18.0/partner-contact-18.0-partner_industry_secondary
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-18-0/partner-contact-18-0-partner_industry_secondary/sl/
Currently translated at 100.0% (17 of 17 strings)

Translation: partner-contact-18.0/partner-contact-18.0-partner_industry_secondary
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-18-0/partner-contact-18-0-partner_industry_secondary/sl/
Copy link

@luisDIXMIT luisDIXMIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash migration commits into a single migration commit.

@muaazsiddiq muaazsiddiq force-pushed the 19.0-mig-partner_industry_secondary branch from 223c978 to fcd14d1 Compare February 10, 2026 11:06
Copy link

@luisDIXMIT luisDIXMIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and tested on runboat, LGTM! Some minor suggestions.

<odoo>
<record id="group_use_partner_industry_for_person" model="res.groups">
<field name="name">Use industry for individuals</field>
<field name="category_id" ref="base.module_category_hidden" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In version 19, res.groups doesn’t use categories directly but can use res.group.privilege. Can you check that there isn’t a res.group.privilege similar to that category? Maybe it uses the same category.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luisDIXMIT In core Odoo, technical groups (previously in category Hidden) were not assigned a privilege. So this seems fine to me. See odoo/odoo@33637d137ed52f5faa

@bouktaibMohssin
Copy link
Member

LGTM

@StefanRijnhart
Copy link
Member

/ocabot migration partner_industry_secondary

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 19.0-ocabot-merge-pr-2283-by-StefanRijnhart-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit f5c4373 into OCA:19.0 Feb 25, 2026
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0bd4453. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.