Skip to content

[18.0][MIG] product_matrix_show_color #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ferran-S73 wants to merge 8 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] product_matrix_show_color #422

ferran-S73 wants to merge 8 commits into from

Conversation

@ferran-S73
Copy link

@ferran-S73 ferran-S73 commented Oct 28, 2025

Migration from #289

@ferran-S73 ferran-S73 force-pushed the 18.0-mig-product_matrix_show_color branch 3 times, most recently from 73ec63e to 1b4d45b Compare October 28, 2025 11:28
@ferran-S73 ferran-S73 force-pushed the 18.0-mig-product_matrix_show_color branch from 1b4d45b to 30f6d12 Compare October 28, 2025 11:31
Reyes4711-S73
Reyes4711-S73 approved these changes Nov 6, 2025
View reviewed changes
Copy link

@Reyes4711-S73 Reyes4711-S73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eugenios73
eugenios73 approved these changes Nov 6, 2025
View reviewed changes
Copy link

@eugenios73 eugenios73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@ferran-S73
Copy link
Author

ferran-S73 commented Nov 7, 2025

@OCA/product-maintainers I'll need some help with this PR's tests if anyone could help me I'd be very thankful.

Context:
Both base modules "product" and "product_matrix" create a product.attribute with the name "Size".
The problem is the module "product_variant_default_code" from this repo implements a constraint on unique attributes name. Then since this module depends on both product and product_matrix and error is thrown when trying to create the constrain as there's already a repeat in attribute's names.

Is there anything we can do in this situation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Reyes4711-S73 Reyes4711-S73 Reyes4711-S73 approved these changes

@eugenios73 eugenios73 eugenios73 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ferran-S73 @Reyes4711-S73 @eugenios73 @OCA-git-bot @miguel-S73 @oca-travis @matteonext