[16.0][FIX]mail_activity_done: Fix counters and activity_state search

[jesusVMayor]

This PR includes 2 changes:

• Remove systray_get_activities overrride, its not necessary since odoo/odoo@bd4e8aa
• Override _search_activity_state adding and mail_activity.done=False to WHERE clause in the query to allow properly search by this field.

Fixes: #1327 CC: @gurneyalex @navarrorico

[jesusVMayor]

Fixed tests.

[jesusVMayor]

I have detected a new bug, the _read_progress_bar inherit was not properly working and the count of activities in the kanban view was wrong. We should modify the subquery where clause

[hbrunn]

looks like you'll have to update the test too - I think it's correct to expect a 0 here

[jesusVMayor]

Seems a problem with the tests because the function executes the query directly. Testing in shell, if i make the commit after the _action_done, the result is 0. It also happens in the test_activity_state_search.

I changed the tests to move the second activity to demo file, assigned to another partner, and created already done.

[StefanRijnhart]

Thanks! Sounds like your test issues could perhaps have been solved with a flush_recordset on the activity.
Do you want to squash your commits in one or maybe two commits? I already picked what remains valid in 18.0 in OCA/mail#31

[jesusVMayor]

Done

[StefanRijnhart]

If I understand correctly, the tests now depend on the demo data. This is against the current grain of making tests less dependent on demo data. The tests are also more reliable if they are for a newly created user. Otherwise, the tests could fail because of demo activities from unrelated modules, or previous activity on a reused database. Can you bring back the test user?

[jesusVMayor]

I made some changes in tests:

• Removed demo data in tests, and use flush_recordset to avoid problems.
• Added tz to new user, odoo base _search_activity_state fails if the user has no tz.
• Create test partner with the test user, it causes some security rules problems if is created without it.

[navarrorico]

Functional review LGTM 👍

[StefanRijnhart]

Thanks for the updates!

/ocabot merge minor

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1507-by-StefanRijnhart-bump-minor, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 2c622c1. Thanks a lot for contributing to OCA. ❤️