Skip to content

[18.0][FIX] mail_gateway: Stop using RecordCapturer#1839

Open
carlos-lopez-tecnativa wants to merge 1 commit intoOCA:18.0from
Tecnativa:18.0-fix-mail_gateway-log
Open

[18.0][FIX] mail_gateway: Stop using RecordCapturer#1839
carlos-lopez-tecnativa wants to merge 1 commit intoOCA:18.0from
Tecnativa:18.0-fix-mail_gateway-log

Conversation

@carlos-lopez-tecnativa
Copy link
Copy Markdown
Contributor

RecordCapturer is only available in tests; it must be avoided in business models. Adapt the code to use a similar feature.

Closes #1812

@Tecnativa @pedrobaeza @percevaq @diegonc could you please review this?

Copy link
Copy Markdown
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why such useful tools are not available outside tests...

@carlos-lopez-tecnativa
Copy link
Copy Markdown
Contributor Author

I don't understand why such useful tools are not available outside tests...

According to this PR odoo/odoo#177671 I understand the underlying reason, but in this case I think the RecordCapturer and other utility functions could be moved to another file. Can I try proposing a PR to Odoo?

@pedrobaeza
Copy link
Copy Markdown
Member

Ask first in that PR if they would accept it (obviously they will refuse it except maybe in master)

RecordCapturer is only available in tests; it must be avoided in business models. Adapt the code to use a similar feature.

Closes OCA#1812
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[18.0][mail_gateway]The module fails to install because it attempts to import the Odoo test.

3 participants