Skip to content

[18.0][IMP] stock_quantity_history_location: invisible location except from Stock view#447

Open
AungKoKoLin1997 wants to merge 3 commits intoOCA:18.0from
qrtl:18.0-imp-stock_quantity_history_location
Open

[18.0][IMP] stock_quantity_history_location: invisible location except from Stock view#447
AungKoKoLin1997 wants to merge 3 commits intoOCA:18.0from
qrtl:18.0-imp-stock_quantity_history_location

Conversation

@AungKoKoLin1997
Copy link
Contributor

Forward port of #423

This PR makes the location field invisible when the model is not product.product (Stock view), because the location context is not used in other models (e.g., stock.valuation.layer) and choosing location will not effect the functionality. So, displaying this field in the pop-up of other models (e.g., Stock Valuation Layer) may confuse users.

@qrtl QT5862

Odoo core behavior has changed, so this module’s redundant code can be removed:
- Drop the include_child_locations flag: child locations are now included by default (see odoo/odoo#78078).
- Remove the company_owned context: it was removed upstream in commit odoo/odoo@6fd0575#diff-2f7d1a089caccb39f6dcaf4afe19af96ebf382886e382b22e1e956ba94a927c9.
@OCA-git-bot
Copy link
Contributor

Hi @luisg123v, @rolandojduartem,
some modules you are maintaining are being modified, check this out!

Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and functional test. LGTM.

Copy link

@kanda999 kanda999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants