[18.0][MIG] hr_timesheet_portal: Migration to 18.0#840
Open
[18.0][MIG] hr_timesheet_portal: Migration to 18.0#840
Conversation
innovara
force-pushed
the
18.0-mig-hr_timesheet_portal
branch
from
3bb6e5a to
c75c3ef
Compare
Contributor
Author
|
@CRogos @BhaveshHeliconia you kindly reviewed the previous migration of this module to |
CRogos
approved these changes
Feb 6, 2026
Contributor
CRogos
left a comment
CRogos
left a comment
There was a problem hiding this comment.
LGTM, but shoudn't we add a suitable user group automatically to the editor group?
maybe hr_timesheet.group_hr_timesheet_user but at least base.user_admin
Currently translated at 100.0% (4 of 4 strings) Translation: timesheet-12.0/timesheet-12.0-hr_timesheet_portal Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-hr_timesheet_portal/it/
Signed-off-by: Manuel Fombuena <mfombuena@innovara.tech>
Signed-off-by: Manuel Fombuena <mfombuena@innovara.tech>
Add USAGE.md and screenshots to improve documentation. Signed-off-by: Manuel Fombuena <mfombuena@innovara.tech>
innovara
force-pushed
the
18.0-mig-hr_timesheet_portal
branch
from
c75c3ef to
ef47739
Compare
…syntax - Add inheritance from group_hr_timesheet_portal to base.group_system. - Update security XML and record rules to Odoo 18 Command syntax. Signed-off-by: Manuel Fombuena <mfombuena@innovara.tech>
innovara
force-pushed
the
18.0-mig-hr_timesheet_portal
branch
from
ef47739 to
62bd903
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This migration follows the recent migration of
hr_timesheet_portalto 17.0. There is already OCA/timesheet#800 for 18.0, but that one is more of a direct drop-in of code that works in 18.0, whereas this PR includes the full commit history and therefore provides traceability of the changes. However, the contribution of its author is acknowledged, as they were added to the list of contributors in the migration to 17.0.Speaking of which:
hr_timesheet_portal/static/src/js/hr_timesheet_portal.esm.js
sessionand bounduserservice with a staticuserimport.browser.setTimeoutinstead of the globalsetTimeoutto satisfy ESLint.this.userbinding and unused imports.hr_timesheet_portal/templates/portal.xml
analytic_account_idwithaccount_id.@hbrunn once again, would you be so kind to review it for me please?